Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactAsset improve error messages #444

Merged
merged 4 commits into from
Jul 23, 2024
Merged

ReactAsset improve error messages #444

merged 4 commits into from
Jul 23, 2024

Conversation

cehan-Chloe
Copy link
Collaborator

@cehan-Chloe cehan-Chloe commented Jul 22, 2024

This pr obsolete #421 which is pointing to bazel-6 with unverified commits.

Issue: #376

What's changed: improve error msg thrown by ReactAsset. more info and react-like errors
Before: if no matched asset found, throw error: No implementation found for id: bar-id type: bar

After:

  1. add check for no assets in registry
  2. modify existing error msg for no match asset found and give possible alternative with fuse.js
    https://www.fusejs.io/demo.html

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Version

Published prerelease version: 0.8.0-next.3

Changelog

Release Notes

JS Package Cleanup (#442)

Fix migration issues in JS packages

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Bazel 6 Migration (#252)

Swaps the repo internals to use bazel@6, rules_js, bazel modules, vitest and tsup for the core + plugin builds


🚀 Enhancement

🐛 Bug Fix

🏠 Internal

📝 Documentation

Authors: 11

@cehan-Chloe cehan-Chloe marked this pull request as ready for review July 22, 2024 15:14
@cehan-Chloe cehan-Chloe removed the request for review from spentacular July 22, 2024 15:39
@KetanReddy
Copy link
Member

Are there any alternatives to string-similarity we can use? It looks like that package isn't being actively maintained so I would be hesitant to add a dependency on it.

@cehan-Chloe
Copy link
Collaborator Author

@KetanReddy replaced string-similarity with fuse.js. thanks for pointing out. Now ready for review

@KetanReddy
Copy link
Member

Looks good! Once CI passes you should be good to merge.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (e8a73e6) to head (6665fc2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   91.71%   91.72%           
=======================================
  Files         338      338           
  Lines       26798    26824   +26     
  Branches     1938     1941    +3     
=======================================
+ Hits        24579    24605   +26     
  Misses       2205     2205           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cehan-Chloe cehan-Chloe merged commit 082b556 into main Jul 23, 2024
11 checks passed
@cehan-Chloe cehan-Chloe deleted the reactasset-errormsg branch July 23, 2024 13:49
This was referenced Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants