-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactAsset improve error messages #444
Conversation
Are there any alternatives to |
@KetanReddy replaced |
Looks good! Once CI passes you should be good to merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 91.71% 91.72%
=======================================
Files 338 338
Lines 26798 26824 +26
Branches 1938 1941 +3
=======================================
+ Hits 24579 24605 +26
Misses 2205 2205
Partials 14 14 ☔ View full report in Codecov by Sentry. |
This pr obsolete #421 which is pointing to bazel-6 with unverified commits.
Issue: #376
What's changed: improve error msg thrown by ReactAsset. more info and react-like errors
Before: if no matched asset found, throw error:
No implementation found for id: bar-id type: bar
After:
https://www.fusejs.io/demo.html
Change Type (required)
Indicate the type of change your pull request is:
patch
minor
major
Does your PR have any documentation updates?
Version
Published prerelease version:
0.8.0-next.3
Changelog
Release Notes
JS Package Cleanup (#442)
Fix migration issues in JS packages
Does your PR have any documentation updates?
Bazel 6 Migration (#252)
Swaps the repo internals to use
bazel@6
,rules_js
, bazel modules,vitest
andtsup
for the core + plugin builds🚀 Enhancement
🐛 Bug Fix
🏠 Internal
📝 Documentation
Authors: 11