ReactAsset improve error messages #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bazel-6 #421 +/- ##
========================================
Coverage 91.75% 91.76%
========================================
Files 339 339
Lines 27044 27068 +24
Branches 1962 1966 +4
========================================
+ Hits 24814 24838 +24
Misses 2216 2216
Partials 14 14 ☔ View full report in Codecov by Sentry. |
cehan-Chloe
changed the title
cehan-Chloe
requested review from
KetanReddy,
adierkens and
spentacular
as code owners
KetanReddy
reviewed
Jul 12, 2024
KetanReddy
reviewed
Jul 12, 2024
KetanReddy
reviewed
Jul 12, 2024
| @@ -75,4 +75,9 @@ export class Registry<V> { | |||
| clear() { | |||
| this.store = createSortedArray<V>(); | |||
| } | |||
|
|
|||
| /** Check if the registry is empty*/ | |||
| isRegistryEmpty() { | |||
There was a problem hiding this comment.
@sugarmanz @hborawski Do we expose the partial match registry on every platform(It doesn't look like we do but I just wanted to check)? If so we should also add this to every platforms API.
There was a problem hiding this comment.
We do have it in iOS, but it's not exposed to users + no Swift API currently
KetanReddy
reviewed
Jul 12, 2024
adierkens
reviewed
Jul 12, 2024
react/player/src/asset/index.tsx
Outdated
Comment on lines
69
to
71
| `No implementation found for id: ${unwrapped.id} type: ${ | ||
| unwrapped.type | ||
| }. This could happen for one of the following reasons: \n |
There was a problem hiding this comment.
Could we check for similarly named types and suggest alternatives?
No implementation found for type: "txt" did you mean "text"?
2b24527 to
64d033b
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #376
Test result: https://app.buildbuddy.io/invocation/8eb077c0-1586-4699-b732-c92c332e7697
What's changed: improve error msg thrown by ReactAsset. more info and react-like errors
Before: if no matched asset found, throw error:
No implementation found for id: bar-id type: barAfter:
add check for no assets in registry
modify existing error msg for no match asset found
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?