Better handle String hashCode collisions in JsLookup (#674)

playframework · Nov 23, 2021 · 533f98a · 533f98a
1 parent 19772a1
commit 533f98a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/benchmarks/src/main/scala/play/api/libs/json/JsonParsing_01_ParseManyFields.scala b/benchmarks/src/main/scala/play/api/libs/json/JsonParsing_01_ParseManyFields.scala
@@ -6,13 +6,21 @@ package play.api.libs.json
 
 import org.openjdk.jmh.annotations._
 
+/**
+  * @see https://github.com/playframework/play-json/pull/193
+  */
 @State(Scope.Benchmark)
 class JsonParsing_01_ParseManyFields {
   @Param(Array("10", "100", "1000", "10000", "100000"))
   var n: Int = 100
 
   var stringToParse: String = _
 
+  case class Example(s: String)
+  object Example {
+    implicit val reads = Json.reads[Example]
+  }
+
   @Setup
   def setup(): Unit = {
     val value = "42"
@@ -21,7 +29,22 @@ class JsonParsing_01_ParseManyFields {
   }
 
   @Benchmark
-  def parseObject(): Unit = {
+  def parseObject(): JsValue = {
     Json.parse(stringToParse)
   }
+
+  @Benchmark
+  def parseObjectAs(): Example = {
+    Json.parse(stringToParse).as[Example]
+  }
+
+  @Benchmark
+  def parseObjectLookup(): JsValue = {
+    (Json.parse(stringToParse) \ "s").as[JsString]
+  }
+
+  @Benchmark
+  def parseObjectValue(): Option[JsValue] = {
+    Json.parse(stringToParse).as[JsObject].value.get("s")
+  }
 }
diff --git a/play-json/shared/src/main/scala/play/api/libs/json/JsLookup.scala b/play-json/shared/src/main/scala/play/api/libs/json/JsLookup.scala
@@ -68,7 +68,7 @@ case class JsLookup(result: JsLookupResult) extends AnyVal {
     case JsDefined(x) =>
       x match {
         case arr: JsObject =>
-          arr.value.get(fieldName) match {
+          arr.underlying.get(fieldName) match {
             case Some(x) => x
             case None    => throw new NoSuchElementException(String.valueOf(fieldName))
           }
@@ -101,7 +101,7 @@ case class JsLookup(result: JsLookupResult) extends AnyVal {
    */
   def \(fieldName: String): JsLookupResult = result match {
     case JsDefined(obj @ JsObject(_)) =>
-      obj.value
+      obj.underlying
         .get(fieldName)
         .map(JsDefined.apply)
         .getOrElse(JsUndefined(s"'$fieldName' is undefined on object: $obj"))
@@ -117,7 +117,7 @@ case class JsLookup(result: JsLookupResult) extends AnyVal {
    */
   def \\(fieldName: String): collection.Seq[JsValue] = result match {
     case JsDefined(obj: JsObject) =>
-      obj.value.foldLeft(Seq[JsValue]())((o, pair) =>
+      obj.underlying.foldLeft(Seq[JsValue]())((o, pair) =>
         pair match {
           case (key, value) if key == fieldName => o ++ (value +: (value \\ fieldName))
           case (_, value)                       => o ++ (value \\ fieldName)