Better handle String hashCode collisions in JsLookup #674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#186 is still exploitable when
JsLookup
is used (jsObject \ "foo"
) orjsObject.value
is called directly.Thankfully, the
Reads
macro doesn't use either of these approaches. Instead, it extracts fields fromjsObject.underlying
(typically ajava.util.LinkedHashMap
). If this approach is good enough for the macro, it seems to make sense to do forJsLookup
as well.jsObject.value
is still vulnerable, but there are no remaining references to it internally after this PR.Before:
After:
Relates to #193. @gmethvin @marcospereira