-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a reusable workflows #705
Conversation
92ebac1
to
842399c
Compare
d247ae3
to
aa34933
Compare
.github/workflows/publish.yml
Outdated
PGP_SECRET: ${{ secrets.PGP_SECRET }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | ||
uses: ihostage/.github/.github/workflows/publish.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 https://github.saobby.my.eu.orgmunity/t/using-organization-secrets-in-reusable-workflows/205207
Need to try without passing secrets explicitly. If it won't work then we'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it didn't work 😞 Need to set secrets explicitly. Hurtful 😞
https://github.com/playframework/play-json/runs/4985224723?check_suite_focus=true
b16a892
to
676318a
Compare
676318a
to
2c63a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and changed to the correct .github repo.
Let's see if mergify merges.
No description provided.