Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a reusable workflows #705

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Conversation

ihostage
Copy link
Member

No description provided.

@ihostage ihostage force-pushed the reusable-workflows branch 5 times, most recently from 92ebac1 to 842399c Compare January 24, 2022 19:19
@ihostage ihostage force-pushed the reusable-workflows branch 5 times, most recently from d247ae3 to aa34933 Compare January 25, 2022 06:36
PGP_SECRET: ${{ secrets.PGP_SECRET }}
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
uses: ihostage/.github/.github/workflows/publish.yml@main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 https://github.saobby.my.eu.orgmunity/t/using-organization-secrets-in-reusable-workflows/205207
Need to try without passing secrets explicitly. If it won't work then we'll change it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it didn't work 😞 Need to set secrets explicitly. Hurtful 😞
https://github.com/playframework/play-json/runs/4985224723?check_suite_focus=true

@ihostage ihostage force-pushed the reusable-workflows branch 5 times, most recently from b16a892 to 676318a Compare February 3, 2022 21:37
@mkurz mkurz force-pushed the reusable-workflows branch from 676318a to 2c63a21 Compare April 10, 2022 21:54
Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and changed to the correct .github repo.
Let's see if mergify merges.

@mkurz mkurz merged commit 725a380 into playframework:main Apr 10, 2022
@ihostage ihostage deleted the reusable-workflows branch April 11, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants