Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable workflows #670

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Apr 11, 2022

Almost the same like playframework/play-json#705

@mkurz mkurz merged commit 0ef82f6 into playframework:main Apr 11, 2022
@mkurz mkurz deleted the reusable-workflows branch April 11, 2022 10:52
@mkurz
Copy link
Member Author

mkurz commented Apr 11, 2022

@ihostage If you see something that should be changed, please let me know 😉

@ihostage
Copy link
Member

Yes, we should release workflows (v1 and v1.0.0) and use

uses: playframework/.github/.github/workflows/sbt.yml@v1

instead 😉
Otherwise we can break an all builds by one small mistake in .github repo 🙃
After successfull test a new version (for example v1.0.1) in one repo we just re-push a tag v1 as link to v1.0.1 and by this action migrate all repos to new stable version 😉
Some details are contained in this GitHub docs https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-release-management-for-actions

@mkurz
Copy link
Member Author

mkurz commented Apr 11, 2022

@ihostage I was waiting with tagging for play-ws, play-json and play-soap to see if everything works. Like you suggested here: playframework/playframework#11142 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants