test check-versioning-lib-release.sh #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebhash
force-pushed
the
dev
branch
2 times, most recently
from
4b28d14
to
6349d87
Compare
…versioning bump `common_messages_sv2` version
…versioning bump `roles_logic_sv2` version
…versioning bump `binary_sv2` version
Add semver check workflow yaml
- Add `start` function and put starting logic there. - Every AbortHandle of each task is stored in a collector, which is a mutex. - Added `kill_tasks` function that takes in input this mutex, access it, pop each JoinHandle and kill the corresponding task. When receive an UpstreamShutdown does the following: 1. waits a random amount of time s 0<s<3 secs (if there 100000 TProxies, then 100000 proxies will connect again _at the same time_). 2. calls `kill_tasks` 3. calls `start` use tokio::task in favor of async_std::task
…-if-disconnected-from-upstream Translator restart if disconnected from upstream
…ass-feature-roles-logic-sv2 bypass `cargo semver-checks --all-features` for roles_logic_sv2
…c-sv2-serde-flag patch `roles_logic_sv2` `with_serde` flag
…r-check use rust stable for semver CI
…kfile update `roles/Cargo.lock`
fixed the fallback to solo-mining in the case that the upstream sends a `SubmitShareError` on a valid share AND there are no other available upstreams in the JDC config.
…fallback-to-solo-mining Fix JDC fallback to solo-mining
rm `release-bin.yaml`
In no-serde-sv2 an sv2 sequence is generic over T. If we want this sequence to be Deserialize we need T to be Fixed and GerMarker. This 2 traits were private since all the sv2 types are already defined in no-serde-sv2. But if we want to use sv2 types defined in an sv2 extensions we need to make these traits public. The Encodable dervive macro in derive_codec implement GetSize for the passed struct. But GetSize is also a blanket implementation for every type that implement Fixed. So if we implement Fixed for our new sv2 type and then we derive Encodable (commonly renamed Serialize) we get an error. This commit add an attribute to Encodable called already_sized if the struct that we want derive Encodable is market as already_sized the macro will not implement GetSize for it. This commit also bump minor version of derive_codec and no-serde-sv2 consequentially also of binary-sv2 since it reexport the above libs.
…nTypes Add support for data types defined by sv2 extensions
rm lib versioning script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.