Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass cargo semver-checks --all-features for roles_logic_sv2 #1100

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 13, 2024

the framing_sv2/with_serde flag was added to roles_logic_sv2 aiming to unblock the SemVer CI introduced via #985

unfortunately the with_serde feature flag is broken for framing_sv2, and that is having undesired consequences on downstream crates that use roles_logic_sv2 as dependencies

this PR allows us to can keep our SemVer CI unblocked by this problem, so that via #1101 we can make sure that roles_logic_sv2 does not include framing_sv2/with_serde

@plebhash plebhash changed the title bypass cargo semver-checks --all-features for roles_logic_sv2 bypass cargo semver-checks --all-features for roles_logic_sv2 Aug 13, 2024
Copy link
Contributor

🐰Bencher

ReportTue, August 13, 2024 at 20:25:32 UTC
ProjectStratum v2 (SRI)
Branchsemver-check-bypass-feature-roles-logic-sv2
Testbedsv2

🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_mining_message_submit_standardLatency (nanoseconds (ns))🚨 (view plot | view alert)14.78 (+0.87%)14.71 (100.50%)
client_sv2_open_channelLatency (nanoseconds (ns))🚨 (view plot | view alert)182.84 (+9.96%)175.18 (104.37%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.27 (-0.63%)45.24 (97.86%)
client_sv2_handle_message_mining✅ (view plot)74.56 (+2.32%)80.40 (92.74%)
client_sv2_mining_message_submit_standard🚨 (view plot | view alert)14.78 (+0.87%)14.71 (100.50%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)284.10 (+7.26%)285.37 (99.55%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)592.96 (-0.23%)627.83 (94.45%)
client_sv2_open_channel🚨 (view plot | view alert)182.84 (+9.96%)175.18 (104.37%)
client_sv2_open_channel_serialize✅ (view plot)271.08 (-4.18%)293.66 (92.31%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)370.82 (-1.96%)423.83 (87.49%)
client_sv2_setup_connection✅ (view plot)161.91 (-1.34%)174.87 (92.59%)
client_sv2_setup_connection_serialize✅ (view plot)445.31 (-6.01%)507.07 (87.82%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)960.29 (-1.10%)1,038.94 (92.43%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportTue, August 13, 2024 at 20:25:32 UTC
ProjectStratum v2 (SRI)
Branchsemver-check-bypass-feature-roles-logic-sv2
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,485.00 (+0.59%)8,724.87 (97.25%)✅ (view plot)3,772.00 (+0.83%)3,856.52 (97.81%)✅ (view plot)5,295.00 (+0.94%)5,403.58 (97.99%)✅ (view plot)8.00 (+0.46%)10.40 (76.90%)✅ (view plot)90.00 (0.00%)93.95 (95.79%)
get_submit✅ (view plot)95,634.00 (+0.08%)96,146.40 (99.47%)✅ (view plot)59,522.00 (+0.08%)59,781.37 (99.57%)✅ (view plot)85,504.00 (+0.11%)85,841.31 (99.61%)✅ (view plot)45.00 (-18.24%)62.85 (71.60%)✅ (view plot)283.00 (+0.32%)287.74 (98.35%)
get_subscribe✅ (view plot)8,004.00 (+0.33%)8,272.23 (96.76%)✅ (view plot)2,848.00 (+0.64%)2,940.32 (96.86%)✅ (view plot)3,984.00 (+0.76%)4,100.35 (97.16%)✅ (view plot)13.00 (-19.66%)19.82 (65.60%)✅ (view plot)113.00 (+0.31%)116.96 (96.61%)
serialize_authorize✅ (view plot)12,328.00 (+0.99%)12,506.86 (98.57%)✅ (view plot)5,343.00 (+0.59%)5,427.52 (98.44%)✅ (view plot)7,458.00 (+0.67%)7,566.93 (98.56%)✅ (view plot)8.00 (-25.68%)13.45 (59.46%)✅ (view plot)138.00 (+1.78%)140.29 (98.37%)
serialize_deserialize_authorize✅ (view plot)24,546.00 (+0.31%)24,709.12 (99.34%)✅ (view plot)9,950.00 (+0.50%)10,028.40 (99.22%)✅ (view plot)14,051.00 (+0.59%)14,154.94 (99.27%)✅ (view plot)34.00 (-7.10%)41.59 (81.75%)✅ (view plot)295.00 (+0.06%)297.66 (99.11%)
serialize_deserialize_handle_authorize✅ (view plot)30,188.00 (+0.14%)30,339.37 (99.50%)✅ (view plot)12,127.00 (+0.26%)12,211.52 (99.31%)✅ (view plot)17,163.00 (+0.26%)17,281.91 (99.31%)✅ (view plot)64.00 (+8.71%)64.97 (98.50%)✅ (view plot)363.00 (-0.22%)366.89 (98.94%)
serialize_deserialize_handle_submit✅ (view plot)126,625.00 (+0.17%)127,040.59 (99.67%)✅ (view plot)73,307.00 (+0.08%)73,623.34 (99.57%)✅ (view plot)105,090.00 (+0.09%)105,517.08 (99.60%)✅ (view plot)114.00 (-5.32%)131.36 (86.79%)✅ (view plot)599.00 (+0.69%)599.44 (99.93%)
serialize_deserialize_handle_subscribe✅ (view plot)27,494.00 (+0.14%)27,602.76 (99.61%)✅ (view plot)9,650.00 (+0.19%)9,742.32 (99.05%)✅ (view plot)13,649.00 (+0.19%)13,776.19 (99.08%)✅ (view plot)67.00 (+1.54%)73.84 (90.74%)✅ (view plot)386.00 (+0.06%)388.55 (99.34%)
serialize_deserialize_submit✅ (view plot)115,333.00 (+0.21%)115,665.10 (99.71%)✅ (view plot)68,167.00 (+0.16%)68,408.12 (99.65%)✅ (view plot)97,843.00 (+0.19%)98,159.98 (99.68%)✅ (view plot)61.00 (-12.06%)75.57 (80.72%)✅ (view plot)491.00 (+0.58%)492.49 (99.70%)
serialize_deserialize_subscribe✅ (view plot)22,948.00 (+0.31%)23,113.95 (99.28%)✅ (view plot)8,209.00 (+0.28%)8,298.28 (98.92%)✅ (view plot)11,568.00 (+0.33%)11,684.11 (99.01%)✅ (view plot)36.00 (-8.63%)44.09 (81.65%)✅ (view plot)320.00 (+0.46%)321.54 (99.52%)
serialize_submit✅ (view plot)100,045.00 (+0.15%)100,477.16 (99.57%)✅ (view plot)61,566.00 (+0.08%)61,830.76 (99.57%)✅ (view plot)88,350.00 (+0.11%)88,694.83 (99.61%)✅ (view plot)43.00 (-22.66%)62.86 (68.40%)✅ (view plot)328.00 (+1.00%)329.36 (99.59%)
serialize_subscribe✅ (view plot)11,439.00 (+0.97%)11,611.48 (98.51%)✅ (view plot)4,195.00 (+0.43%)4,287.32 (97.85%)✅ (view plot)5,839.00 (+0.46%)5,959.51 (97.98%)✅ (view plot)14.00 (-14.35%)19.01 (73.63%)✅ (view plot)158.00 (+1.74%)159.90 (98.81%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportTue, August 13, 2024 at 20:25:36 UTC
ProjectStratum v2 (SRI)
Branch1100/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,479.30 (-6.48%)7,351.53 (88.14%)
client-submit-serialize-deserialize✅ (view plot)7,262.50 (-7.41%)8,348.70 (86.99%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)7,932.10 (-5.72%)8,851.65 (89.61%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)911.74 (+1.43%)927.42 (98.31%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)712.97 (+2.23%)719.07 (99.15%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)248.83 (+0.27%)255.22 (97.50%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.57 (+0.25%)162.47 (96.99%)
client-sv1-get-submit✅ (view plot)6,298.50 (-5.91%)7,141.18 (88.20%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)277.02 (-0.55%)291.22 (95.12%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)770.81 (+3.10%)777.83 (99.10%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)631.71 (+2.75%)638.93 (98.87%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)205.13 (-0.75%)220.00 (93.24%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

🐰Bencher

ReportTue, August 13, 2024 at 20:25:37 UTC
ProjectStratum v2 (SRI)
Branchsemver-check-bypass-feature-roles-logic-sv2
Testbedsv2

🚨 7 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)13.00 (+84.25%)11.22 (115.91%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.30 (100.21%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,407.00 (+0.43%)15,375.10 (100.21%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.69 (100.22%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,672.00 (+0.49%)11,648.55 (100.20%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.29%)14,837.01 (100.12%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,819.00 (+0.31%)21,786.72 (100.15%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,123.00 (+3.53%)2,130.52 (99.65%)✅ (view plot)473.00 (+0.49%)486.40 (97.25%)✅ (view plot)728.00 (-0.56%)755.19 (96.40%)🚨 (view plot | view alert)13.00 (+84.25%)11.22 (115.91%)✅ (view plot)38.00 (+3.64%)38.61 (98.42%)
client_sv2_handle_message_mining✅ (view plot)8,239.00 (+0.51%)8,337.39 (98.82%)✅ (view plot)2,143.00 (+0.73%)2,171.62 (98.68%)✅ (view plot)3,169.00 (+0.77%)3,216.53 (98.52%)✅ (view plot)34.00 (-11.56%)43.68 (77.85%)✅ (view plot)140.00 (+0.81%)142.01 (98.58%)
client_sv2_mining_message_submit_standard✅ (view plot)6,298.00 (+0.35%)6,388.92 (98.58%)✅ (view plot)1,756.00 (+0.36%)1,763.42 (99.58%)✅ (view plot)2,558.00 (+0.16%)2,576.06 (99.30%)✅ (view plot)20.00 (+14.04%)22.71 (88.08%)✅ (view plot)104.00 (+0.16%)106.91 (97.28%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,805.00 (+0.20%)15,034.83 (98.47%)✅ (view plot)4,700.00 (+0.14%)4,707.42 (99.84%)✅ (view plot)6,760.00 (+0.08%)6,775.46 (99.77%)✅ (view plot)48.00 (+1.49%)52.19 (91.98%)✅ (view plot)223.00 (+0.26%)229.99 (96.96%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,587.00 (+0.39%)27,847.57 (99.06%)🚨 (view plot | view alert)10,591.00 (+0.45%)10,568.30 (100.21%)🚨 (view plot | view alert)15,407.00 (+0.43%)15,375.10 (100.21%)✅ (view plot)84.00 (+0.33%)89.34 (94.02%)✅ (view plot)336.00 (+0.34%)345.35 (97.29%)
client_sv2_open_channel✅ (view plot)4,281.00 (-4.62%)4,621.21 (92.64%)✅ (view plot)1,461.00 (+0.06%)1,474.45 (99.09%)✅ (view plot)2,161.00 (+0.38%)2,173.21 (99.44%)✅ (view plot)11.00 (-8.05%)15.23 (72.23%)✅ (view plot)59.00 (-9.26%)68.52 (86.11%)
client_sv2_open_channel_serialize✅ (view plot)13,986.00 (-1.60%)14,465.72 (96.68%)✅ (view plot)5,064.00 (+0.02%)5,077.45 (99.74%)✅ (view plot)7,326.00 (+0.11%)7,339.54 (99.82%)✅ (view plot)37.00 (-0.70%)41.99 (88.12%)✅ (view plot)185.00 (-3.49%)199.03 (92.95%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,617.00 (-0.10%)23,024.14 (98.23%)🚨 (view plot | view alert)8,027.00 (+0.53%)8,009.69 (100.22%)🚨 (view plot | view alert)11,672.00 (+0.49%)11,648.55 (100.20%)✅ (view plot)82.00 (+11.62%)82.36 (99.57%)✅ (view plot)301.00 (-1.15%)314.99 (95.56%)
client_sv2_setup_connection✅ (view plot)4,647.00 (-1.07%)4,765.45 (97.51%)✅ (view plot)1,502.00 (+0.05%)1,515.45 (99.11%)✅ (view plot)2,277.00 (+0.01%)2,299.74 (99.01%)✅ (view plot)12.00 (+31.44%)13.68 (87.73%)✅ (view plot)66.00 (-2.73%)69.68 (94.72%)
client_sv2_setup_connection_serialize✅ (view plot)16,066.00 (-1.20%)16,495.26 (97.40%)✅ (view plot)5,963.00 (+0.01%)5,976.45 (99.77%)✅ (view plot)8,661.00 (+0.07%)8,677.76 (99.81%)✅ (view plot)46.00 (+3.03%)49.00 (93.88%)✅ (view plot)205.00 (-2.82%)217.66 (94.18%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,504.00 (-0.08%)35,747.15 (99.32%)🚨 (view plot | view alert)14,855.00 (+0.29%)14,837.01 (100.12%)🚨 (view plot | view alert)21,819.00 (+0.31%)21,786.72 (100.15%)✅ (view plot)98.00 (-1.60%)112.67 (86.98%)✅ (view plot)377.00 (-0.67%)384.61 (98.02%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@GitGab19 GitGab19 merged commit d4c6c0c into stratum-mining:dev Aug 13, 2024
33 checks passed
@plebhash plebhash mentioned this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants