Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.2 #1112

Merged
merged 129 commits into from
Aug 20, 2024
Merged

Release 1.0.2 #1112

merged 129 commits into from
Aug 20, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 18, 2024

Global Release v1.0.2

PR Changelog

xyephy and others added 30 commits May 31, 2024 13:33
..to `TryFrom<(u8, &'a mut [u8])> for PoolMessages`
pavlenex and others added 14 commits August 13, 2024 18:12
…ed-from-upstream

Translator restart if disconnected from upstream
…les-logic-sv2

bypass `cargo semver-checks --all-features` for roles_logic_sv2
fixed the fallback to solo-mining in the case that the
upstream sends a `SubmitShareError` on a valid share AND there are no
other available upstreams in the JDC config.
…lo-mining

Fix JDC fallback to solo-mining
@plebhash plebhash added the release Important for upcoming release label Aug 18, 2024
In no-serde-sv2 an sv2 sequence is generic over T. If we want this
sequence to be Deserialize we need T to be Fixed and GerMarker. This 2
traits were private since all the sv2 types are already defined in
no-serde-sv2. But if we want to use sv2 types defined in an sv2
extensions we need to make these traits public.

The Encodable dervive macro in derive_codec implement GetSize for the
passed struct. But GetSize is also a blanket implementation for every
type that implement Fixed. So if we implement Fixed for our new sv2 type
and then we derive Encodable (commonly renamed Serialize) we get an
error. This commit add an attribute to Encodable called already_sized if the
struct that we want derive Encodable is market as already_sized the
macro will not implement GetSize for it.

This commit also bump minor version of derive_codec and no-serde-sv2
consequentially also of binary-sv2 since it reexport the above libs.
Add support for data types defined by sv2 extensions
Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 20:31:13 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv2

🚨 9 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonL2 Accesses (accesses)🚨 (view plot | view alert)14.00 (+97.52%)11.35 (123.31%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.44%)10,572.67 (100.17%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,406.00 (+0.41%)15,379.85 (100.17%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.52%)8,012.48 (100.18%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,669.00 (+0.46%)11,650.30 (100.16%)
client_sv2_open_channel_serialize_deserializeL2 Accesses (accesses)🚨 (view plot | view alert)84.00 (+13.95%)83.12 (101.06%)
client_sv2_setup_connectionL2 Accesses (accesses)🚨 (view plot | view alert)14.00 (+52.00%)13.98 (100.13%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.29%)14,839.90 (100.10%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,815.00 (+0.28%)21,789.85 (100.12%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,093.00 (+1.90%)2,139.28 (97.84%)✅ (view plot)473.00 (+0.46%)486.12 (97.30%)✅ (view plot)728.00 (-0.57%)754.66 (96.47%)🚨 (view plot | view alert)14.00 (+97.52%)11.35 (123.31%)✅ (view plot)37.00 (+0.67%)38.85 (95.24%)
client_sv2_handle_message_mining✅ (view plot)8,251.00 (+0.64%)8,336.09 (98.98%)✅ (view plot)2,143.00 (+0.70%)2,171.59 (98.68%)✅ (view plot)3,166.00 (+0.64%)3,216.21 (98.44%)✅ (view plot)37.00 (-3.52%)43.45 (85.16%)✅ (view plot)140.00 (+0.80%)141.96 (98.62%)
client_sv2_mining_message_submit_standard✅ (view plot)6,306.00 (+0.44%)6,393.90 (98.63%)✅ (view plot)1,756.00 (+0.35%)1,763.49 (99.58%)✅ (view plot)2,556.00 (+0.08%)2,575.50 (99.24%)✅ (view plot)22.00 (+24.90%)22.89 (96.09%)✅ (view plot)104.00 (+0.10%)106.96 (97.23%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,805.00 (+0.15%)15,034.98 (98.47%)✅ (view plot)4,700.00 (+0.13%)4,707.49 (99.84%)✅ (view plot)6,760.00 (+0.08%)6,775.05 (99.78%)✅ (view plot)48.00 (+1.67%)51.64 (92.94%)✅ (view plot)223.00 (+0.17%)229.95 (96.98%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,591.00 (+0.38%)27,851.74 (99.06%)🚨 (view plot | view alert)10,591.00 (+0.44%)10,572.67 (100.17%)🚨 (view plot | view alert)15,406.00 (+0.41%)15,379.85 (100.17%)✅ (view plot)85.00 (+1.55%)89.09 (95.41%)✅ (view plot)336.00 (+0.28%)345.30 (97.31%)
client_sv2_open_channel✅ (view plot)4,327.00 (-3.61%)4,618.96 (93.68%)✅ (view plot)1,461.00 (+0.05%)1,474.10 (99.11%)✅ (view plot)2,157.00 (+0.20%)2,172.49 (99.29%)✅ (view plot)14.00 (+15.82%)15.34 (91.25%)✅ (view plot)60.00 (-7.72%)68.51 (87.58%)
client_sv2_open_channel_serialize✅ (view plot)14,054.00 (-1.14%)14,455.56 (97.22%)✅ (view plot)5,064.00 (+0.02%)5,077.10 (99.74%)✅ (view plot)7,324.00 (+0.08%)7,339.08 (99.79%)✅ (view plot)37.00 (-0.24%)41.33 (89.51%)✅ (view plot)187.00 (-2.51%)198.69 (94.12%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,659.00 (+0.05%)23,022.77 (98.42%)🚨 (view plot | view alert)8,027.00 (+0.52%)8,012.48 (100.18%)🚨 (view plot | view alert)11,669.00 (+0.46%)11,650.30 (100.16%)🚨 (view plot | view alert)84.00 (+13.95%)83.12 (101.06%)✅ (view plot)302.00 (-0.88%)314.75 (95.95%)
client_sv2_setup_connection✅ (view plot)4,655.00 (-0.95%)4,766.15 (97.67%)✅ (view plot)1,502.00 (+0.05%)1,515.10 (99.14%)✅ (view plot)2,275.00 (-0.08%)2,299.09 (98.95%)🚨 (view plot | view alert)14.00 (+52.00%)13.98 (100.13%)✅ (view plot)66.00 (-2.82%)69.64 (94.77%)
client_sv2_setup_connection_serialize✅ (view plot)16,146.00 (-0.77%)16,481.97 (97.96%)✅ (view plot)5,963.00 (+0.01%)5,976.10 (99.78%)✅ (view plot)8,656.00 (+0.01%)8,676.63 (99.76%)✅ (view plot)49.00 (+9.19%)49.64 (98.72%)✅ (view plot)207.00 (-1.99%)217.18 (95.31%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,550.00 (+0.02%)35,750.76 (99.44%)🚨 (view plot | view alert)14,855.00 (+0.29%)14,839.90 (100.10%)🚨 (view plot | view alert)21,815.00 (+0.28%)21,789.85 (100.12%)✅ (view plot)101.00 (+1.28%)112.36 (89.89%)✅ (view plot)378.00 (-0.46%)384.34 (98.35%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 20:31:11 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
Estimated Cycles Upper Boundary
estimated cycles | (%)
InstructionsInstructions Results
instructions | (Δ%)
Instructions Upper Boundary
instructions | (%)
L1 AccessesL1 Accesses Results
accesses | (Δ%)
L1 Accesses Upper Boundary
accesses | (%)
L2 AccessesL2 Accesses Results
accesses | (Δ%)
L2 Accesses Upper Boundary
accesses | (%)
RAM AccessesRAM Accesses Results
accesses | (Δ%)
RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,473.00 (+0.53%)8,743.64 (96.90%)✅ (view plot)3,772.00 (+0.88%)3,864.62 (97.60%)✅ (view plot)5,298.00 (+1.03%)5,414.21 (97.85%)✅ (view plot)5.00 (-35.70%)10.56 (47.33%)✅ (view plot)90.00 (+0.13%)94.17 (95.57%)
get_submit✅ (view plot)95,646.00 (+0.10%)96,169.87 (99.46%)✅ (view plot)59,522.00 (+0.09%)59,780.61 (99.57%)✅ (view plot)85,501.00 (+0.11%)85,839.98 (99.61%)✅ (view plot)48.00 (-12.59%)62.64 (76.62%)✅ (view plot)283.00 (+0.40%)288.73 (98.02%)
get_subscribe✅ (view plot)8,026.00 (+0.67%)8,297.26 (96.73%)✅ (view plot)2,848.00 (+0.74%)2,949.17 (96.57%)✅ (view plot)3,986.00 (+0.90%)4,112.05 (96.93%)✅ (view plot)10.00 (-37.50%)20.26 (49.36%)✅ (view plot)114.00 (+1.22%)117.37 (97.13%)
serialize_authorize✅ (view plot)12,324.00 (+0.98%)12,534.85 (98.32%)✅ (view plot)5,343.00 (+0.62%)5,435.62 (98.30%)✅ (view plot)7,459.00 (+0.71%)7,577.24 (98.44%)✅ (view plot)7.00 (-33.98%)13.68 (51.19%)✅ (view plot)138.00 (+1.79%)140.76 (98.04%)
serialize_deserialize_authorize✅ (view plot)24,602.00 (+0.54%)24,726.29 (99.50%)✅ (view plot)9,950.00 (+0.50%)10,035.83 (99.14%)✅ (view plot)14,052.00 (+0.60%)14,164.99 (99.20%)✅ (view plot)31.00 (-15.03%)41.84 (74.10%)✅ (view plot)297.00 (+0.75%)297.76 (99.74%)
serialize_deserialize_handle_authorize✅ (view plot)30,228.00 (+0.30%)30,373.41 (99.52%)✅ (view plot)12,127.00 (+0.27%)12,219.62 (99.24%)✅ (view plot)17,168.00 (+0.30%)17,291.72 (99.28%)✅ (view plot)57.00 (-2.99%)64.63 (88.19%)✅ (view plot)365.00 (+0.38%)367.17 (99.41%)
serialize_deserialize_handle_submit✅ (view plot)126,601.00 (+0.16%)127,078.02 (99.62%)✅ (view plot)73,307.00 (+0.08%)73,626.13 (99.57%)✅ (view plot)105,096.00 (+0.10%)105,521.68 (99.60%)✅ (view plot)108.00 (-9.79%)132.07 (81.77%)✅ (view plot)599.00 (+0.73%)600.62 (99.73%)
serialize_deserialize_handle_subscribe✅ (view plot)27,546.00 (+0.35%)27,646.00 (99.64%)✅ (view plot)9,650.00 (+0.22%)9,751.17 (98.96%)✅ (view plot)13,651.00 (+0.23%)13,787.23 (99.01%)✅ (view plot)63.00 (-4.42%)73.58 (85.62%)✅ (view plot)388.00 (+0.59%)388.95 (99.76%)
serialize_deserialize_submit✅ (view plot)115,363.00 (+0.24%)115,686.54 (99.72%)✅ (view plot)68,167.00 (+0.15%)68,409.45 (99.65%)✅ (view plot)97,843.00 (+0.18%)98,164.31 (99.67%)✅ (view plot)60.00 (-13.30%)76.07 (78.88%)✅ (view plot)492.00 (+0.82%)493.52 (99.69%)
serialize_deserialize_subscribe✅ (view plot)23,016.00 (+0.62%)23,140.69 (99.46%)✅ (view plot)8,209.00 (+0.31%)8,306.85 (98.82%)✅ (view plot)11,566.00 (+0.34%)11,695.10 (98.90%)✅ (view plot)36.00 (-8.58%)44.01 (81.80%)✅ (view plot)322.00 (+1.07%)322.07 (99.98%)
serialize_submit✅ (view plot)100,053.00 (+0.16%)100,504.88 (99.55%)✅ (view plot)61,566.00 (+0.08%)61,829.72 (99.57%)✅ (view plot)88,348.00 (+0.11%)88,693.31 (99.61%)✅ (view plot)45.00 (-18.89%)63.02 (71.40%)✅ (view plot)328.00 (+1.04%)330.78 (99.16%)
serialize_subscribe✅ (view plot)11,465.00 (+1.21%)11,646.03 (98.45%)✅ (view plot)4,195.00 (+0.50%)4,296.17 (97.65%)✅ (view plot)5,840.00 (+0.54%)5,971.00 (97.81%)✅ (view plot)12.00 (-26.11%)19.32 (62.10%)✅ (view plot)159.00 (+2.33%)160.58 (99.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 20:31:13 UTC
ProjectStratum v2 (SRI)
Branch1112/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,542.10 (-5.36%)7,364.71 (88.83%)
client-submit-serialize-deserialize✅ (view plot)7,377.50 (-5.84%)8,357.36 (88.28%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,026.00 (-4.49%)8,857.43 (90.61%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)916.46 (+1.99%)926.40 (98.93%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)702.02 (+0.62%)718.72 (97.68%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)251.12 (+1.12%)255.76 (98.19%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.28 (-0.02%)162.82 (96.60%)
client-sv1-get-submit✅ (view plot)6,371.50 (-4.60%)7,157.15 (89.02%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)277.73 (-0.31%)290.83 (95.50%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)755.35 (+1.03%)775.99 (97.34%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)604.74 (-1.52%)638.03 (94.78%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)202.31 (-1.97%)219.47 (92.18%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link
Contributor

github-actions bot commented Aug 19, 2024

🐰Bencher

ReportMon, August 19, 2024 at 20:31:11 UTC
ProjectStratum v2 (SRI)
Branchdev
Testbedsv2

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonLatency (nanoseconds (ns))🚨 (view plot | view alert)45.51 (+2.07%)45.33 (100.38%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)45.51 (+2.07%)45.33 (100.38%)
client_sv2_handle_message_mining✅ (view plot)72.40 (-0.89%)80.90 (89.49%)
client_sv2_mining_message_submit_standard✅ (view plot)14.64 (-0.07%)14.69 (99.63%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)277.43 (+4.84%)284.07 (97.66%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)583.56 (-1.69%)626.71 (93.12%)
client_sv2_open_channel✅ (view plot)161.99 (-2.11%)171.51 (94.45%)
client_sv2_open_channel_serialize✅ (view plot)278.66 (-1.51%)293.48 (94.95%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)382.39 (+0.74%)427.70 (89.41%)
client_sv2_setup_connection✅ (view plot)155.39 (-5.24%)175.01 (88.79%)
client_sv2_setup_connection_serialize✅ (view plot)462.01 (-2.47%)504.60 (91.56%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)971.41 (-0.21%)1,045.53 (92.91%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

fi3 and others added 5 commits August 19, 2024 19:59
In order to implement Encodable (aka Serialize) for sv2 type defined by
extensions EncodablePrimitive is needed.
Update binary-sv2/no-serde-sv2 excport EncodablePrimitive
Copy link
Collaborator

@rrybarczyk rrybarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@plebhash plebhash merged commit bb0f5a3 into main Aug 20, 2024
67 of 70 checks passed
@plebhash plebhash added this to the 1.0.2 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Important for upcoming release
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.