Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove job distribution protocol #1072

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Remove job distribution protocol #1072

merged 3 commits into from
Jul 30, 2024

Conversation

Shourya742
Copy link
Contributor

Closes: #1065

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

🐰Bencher

ReportTue, July 30, 2024 at 04:49:58 UTC
ProjectStratum v2 (SRI)
Branchremove-job-distribution-protocol
Testbedsv1

🚨 2 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
serialize_deserialize_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)299.00 (+1.31%)298.67 (100.11%)
serialize_deserialize_handle_authorizeRAM Accesses (accesses)🚨 (view plot | view alert)369.00 (+1.31%)368.41 (100.16%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,538.00 (+1.13%)8,726.28 (97.84%)✅ (view plot)3,746.00 (+0.14%)3,852.15 (97.24%)✅ (view plot)5,248.00 (+0.05%)5,396.93 (97.24%)✅ (view plot)7.00 (-11.18%)10.30 (67.96%)✅ (view plot)93.00 (+3.08%)94.33 (98.59%)
get_submit✅ (view plot)95,509.00 (-0.04%)96,119.46 (99.36%)✅ (view plot)59,439.00 (-0.05%)59,766.90 (99.45%)✅ (view plot)85,359.00 (-0.05%)85,820.09 (99.46%)✅ (view plot)49.00 (-10.41%)62.59 (78.29%)✅ (view plot)283.00 (+0.31%)287.57 (98.41%)
get_subscribe✅ (view plot)7,991.00 (+0.17%)8,261.36 (96.73%)✅ (view plot)2,841.00 (+0.36%)2,937.27 (96.72%)✅ (view plot)3,971.00 (+0.40%)4,096.53 (96.94%)✅ (view plot)13.00 (-18.58%)19.85 (65.48%)✅ (view plot)113.00 (+0.32%)116.81 (96.74%)
serialize_authorize✅ (view plot)12,291.00 (+0.65%)12,501.62 (98.32%)✅ (view plot)5,317.00 (+0.10%)5,423.15 (98.04%)✅ (view plot)7,411.00 (+0.04%)7,560.28 (98.03%)✅ (view plot)10.00 (-6.94%)13.27 (75.36%)✅ (view plot)138.00 (+1.69%)140.37 (98.31%)
serialize_deserialize_authorize✅ (view plot)24,588.00 (+0.45%)24,716.03 (99.48%)✅ (view plot)9,898.00 (-0.02%)10,022.11 (98.76%)✅ (view plot)13,958.00 (-0.06%)14,144.76 (98.68%)✅ (view plot)33.00 (-9.19%)41.55 (79.42%)🚨 (view plot | view alert)299.00 (+1.31%)298.67 (100.11%)
serialize_deserialize_handle_authorize✅ (view plot)30,331.00 (+0.57%)30,375.40 (99.85%)✅ (view plot)12,101.00 (+0.04%)12,207.15 (99.13%)✅ (view plot)17,116.00 (-0.01%)17,274.79 (99.08%)✅ (view plot)60.00 (+1.87%)64.67 (92.78%)🚨 (view plot | view alert)369.00 (+1.31%)368.41 (100.16%)
serialize_deserialize_handle_submit✅ (view plot)126,406.00 (-0.00%)127,010.87 (99.52%)✅ (view plot)73,224.00 (-0.03%)73,606.64 (99.48%)✅ (view plot)104,946.00 (-0.04%)105,492.49 (99.48%)✅ (view plot)120.00 (-0.39%)130.89 (91.68%)✅ (view plot)596.00 (+0.18%)599.20 (99.47%)
serialize_deserialize_handle_subscribe✅ (view plot)27,529.00 (+0.25%)27,607.02 (99.72%)✅ (view plot)9,643.00 (+0.11%)9,739.27 (99.01%)✅ (view plot)13,639.00 (+0.11%)13,772.04 (99.03%)✅ (view plot)62.00 (-5.58%)73.53 (84.32%)✅ (view plot)388.00 (+0.54%)388.82 (99.79%)
serialize_deserialize_submit✅ (view plot)114,999.00 (-0.07%)115,630.58 (99.45%)✅ (view plot)68,001.00 (-0.08%)68,389.11 (99.43%)✅ (view plot)97,559.00 (-0.09%)98,130.66 (99.42%)✅ (view plot)65.00 (-5.98%)75.26 (86.37%)✅ (view plot)489.00 (+0.17%)492.32 (99.33%)
serialize_deserialize_subscribe✅ (view plot)22,922.00 (+0.19%)23,107.36 (99.20%)✅ (view plot)8,195.00 (+0.10%)8,294.75 (98.80%)✅ (view plot)11,542.00 (+0.10%)11,679.10 (98.83%)✅ (view plot)36.00 (-8.09%)44.03 (81.75%)✅ (view plot)320.00 (+0.44%)321.56 (99.52%)
serialize_submit✅ (view plot)99,826.00 (-0.06%)100,447.30 (99.38%)✅ (view plot)61,483.00 (-0.05%)61,816.10 (99.46%)✅ (view plot)88,206.00 (-0.05%)88,673.40 (99.47%)✅ (view plot)49.00 (-11.32%)62.53 (78.36%)✅ (view plot)325.00 (+0.10%)329.04 (98.77%)
serialize_subscribe✅ (view plot)11,328.00 (+0.02%)11,596.88 (97.68%)✅ (view plot)4,188.00 (+0.25%)4,284.27 (97.75%)✅ (view plot)5,828.00 (+0.25%)5,955.59 (97.86%)✅ (view plot)15.00 (-7.81%)18.89 (79.41%)✅ (view plot)155.00 (-0.12%)159.59 (97.13%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

🐰Bencher

ReportTue, July 30, 2024 at 04:49:59 UTC
ProjectStratum v2 (SRI)
Branch1072/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,515.50 (-5.38%)7,369.19 (88.42%)
client-submit-serialize-deserialize✅ (view plot)7,433.90 (-4.77%)8,339.23 (89.14%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,038.70 (-4.02%)8,857.43 (90.76%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)899.45 (+0.15%)925.36 (97.20%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)702.89 (+0.88%)716.90 (98.05%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)246.85 (-0.55%)255.41 (96.65%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.59 (+0.19%)162.37 (97.06%)
client-sv1-get-submit✅ (view plot)6,334.70 (-4.83%)7,142.84 (88.69%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)278.32 (-0.12%)290.64 (95.76%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)755.50 (+0.85%)780.82 (96.76%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)612.44 (-0.24%)636.83 (96.17%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)200.82 (-2.71%)219.24 (91.60%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

🐰Bencher

ReportTue, July 30, 2024 at 04:50:00 UTC
ProjectStratum v2 (SRI)
Branchremove-job-distribution-protocol
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.80 (+0.52%)45.24 (99.04%)
client_sv2_handle_message_mining✅ (view plot)73.64 (+0.72%)80.89 (91.04%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.17%)14.69 (99.56%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)264.84 (+0.14%)283.70 (93.35%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)614.18 (+3.22%)628.02 (97.80%)
client_sv2_open_channel✅ (view plot)168.72 (+1.38%)174.33 (96.78%)
client_sv2_open_channel_serialize✅ (view plot)278.29 (-1.50%)293.32 (94.88%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)373.24 (-1.20%)421.85 (88.48%)
client_sv2_setup_connection✅ (view plot)168.98 (+2.70%)175.21 (96.44%)
client_sv2_setup_connection_serialize✅ (view plot)445.49 (-5.61%)507.09 (87.85%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)973.99 (+0.37%)1,036.75 (93.95%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited
Loading

🐰Bencher

ReportTue, July 30, 2024 at 04:49:59 UTC
ProjectStratum v2 (SRI)
Branchremove-job-distribution-protocol
Testbedsv2

🚨 8 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_handle_message_commonEstimated Cycles (estimated cycles)🚨 (view plot | view alert)2,153.00 (+4.65%)2,149.73 (100.15%)
client_sv2_handle_message_commonRAM Accesses (accesses)🚨 (view plot | view alert)39.00 (+6.00%)38.92 (100.20%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,591.00 (+0.42%)10,584.46 (100.06%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,405.00 (+0.38%)15,396.78 (100.05%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,027.00 (+0.49%)8,023.31 (100.05%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,675.00 (+0.47%)11,668.68 (100.05%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,855.00 (+0.27%)14,850.98 (100.03%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,813.00 (+0.26%)21,806.33 (100.03%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common🚨 (view plot | view alert)2,153.00 (+4.65%)2,149.73 (100.15%)✅ (view plot)473.00 (+0.37%)487.14 (97.10%)✅ (view plot)728.00 (-0.60%)755.01 (96.42%)✅ (view plot)12.00 (+61.48%)12.39 (96.89%)🚨 (view plot | view alert)39.00 (+6.00%)38.92 (100.20%)
client_sv2_handle_message_mining✅ (view plot)8,213.00 (+0.18%)8,333.03 (98.56%)✅ (view plot)2,143.00 (+0.68%)2,171.87 (98.67%)✅ (view plot)3,168.00 (+0.69%)3,216.43 (98.49%)✅ (view plot)36.00 (-6.16%)43.39 (82.98%)✅ (view plot)139.00 (+0.10%)141.87 (97.98%)
client_sv2_mining_message_submit_standard✅ (view plot)6,340.00 (+0.96%)6,393.48 (99.16%)✅ (view plot)1,756.00 (+0.32%)1,765.43 (99.47%)✅ (view plot)2,555.00 (+0.02%)2,576.73 (99.16%)✅ (view plot)22.00 (+22.69%)23.72 (92.76%)✅ (view plot)105.00 (+1.08%)106.88 (98.24%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,855.00 (+0.50%)15,033.90 (98.81%)✅ (view plot)4,700.00 (+0.12%)4,709.43 (99.80%)✅ (view plot)6,755.00 (-0.00%)6,776.03 (99.69%)✅ (view plot)52.00 (+8.92%)53.40 (97.37%)✅ (view plot)224.00 (+0.67%)229.81 (97.47%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,625.00 (+0.49%)27,851.64 (99.19%)🚨 (view plot | view alert)10,591.00 (+0.42%)10,584.46 (100.06%)🚨 (view plot | view alert)15,405.00 (+0.38%)15,396.78 (100.05%)✅ (view plot)85.00 (+1.34%)89.41 (95.06%)✅ (view plot)337.00 (+0.61%)345.12 (97.65%)
client_sv2_open_channel✅ (view plot)4,353.00 (-2.81%)4,624.61 (94.13%)✅ (view plot)1,461.00 (+0.02%)1,475.00 (99.05%)✅ (view plot)2,158.00 (+0.19%)2,175.15 (99.21%)✅ (view plot)12.00 (+0.14%)15.12 (79.38%)✅ (view plot)61.00 (-5.75%)68.78 (88.69%)
client_sv2_open_channel_serialize✅ (view plot)14,084.00 (-0.85%)14,454.90 (97.43%)✅ (view plot)5,064.00 (+0.01%)5,078.00 (99.72%)✅ (view plot)7,324.00 (+0.07%)7,341.40 (99.76%)✅ (view plot)36.00 (-3.24%)41.79 (86.15%)✅ (view plot)188.00 (-1.79%)198.74 (94.59%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,665.00 (+0.10%)23,011.91 (98.49%)🚨 (view plot | view alert)8,027.00 (+0.49%)8,023.31 (100.05%)🚨 (view plot | view alert)11,675.00 (+0.47%)11,668.68 (100.05%)✅ (view plot)77.00 (+4.44%)82.47 (93.37%)✅ (view plot)303.00 (-0.45%)314.52 (96.34%)
client_sv2_setup_connection✅ (view plot)4,723.00 (+0.51%)4,764.08 (99.14%)✅ (view plot)1,502.00 (+0.02%)1,516.00 (99.08%)✅ (view plot)2,273.00 (-0.18%)2,299.71 (98.84%)✅ (view plot)14.00 (+47.37%)14.70 (95.26%)✅ (view plot)68.00 (+0.23%)69.58 (97.73%)
client_sv2_setup_connection_serialize✅ (view plot)16,180.00 (-0.47%)16,482.67 (98.16%)✅ (view plot)5,963.00 (+0.01%)5,977.00 (99.77%)✅ (view plot)8,655.00 (-0.01%)8,678.07 (99.73%)✅ (view plot)49.00 (+8.76%)50.16 (97.68%)✅ (view plot)208.00 (-1.30%)217.36 (95.69%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,588.00 (+0.14%)35,744.98 (99.56%)🚨 (view plot | view alert)14,855.00 (+0.27%)14,850.98 (100.03%)🚨 (view plot | view alert)21,813.00 (+0.26%)21,806.33 (100.03%)✅ (view plot)102.00 (+2.12%)112.59 (90.59%)✅ (view plot)379.00 (-0.13%)384.38 (98.60%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@Shourya742 Shourya742 force-pushed the remove-job-distribution-protocol branch from 97f194b to f9e5f02 Compare July 25, 2024 11:39
@Shourya742 Shourya742 marked this pull request as ready for review July 27, 2024 03:48
@plebhash
Copy link
Collaborator

rebasing so we can merge

@plebhash plebhash force-pushed the remove-job-distribution-protocol branch from 8087599 to acf9534 Compare July 29, 2024 21:33
@plebhash plebhash merged commit d495151 into stratum-mining:dev Jul 30, 2024
32 checks passed
@plebhash plebhash mentioned this pull request Aug 18, 2024
Merged
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 26, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
397b249 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 28, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
1b17e5a 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 28, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
77fe5e0 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 28, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
4602fbc 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 28, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
6791ca0 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 29, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
9dbd45a 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 29, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
2595b1b 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 29, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
e61588d 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 31, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
99c971d 
companion to stratum-mining/stratum#1072
plebhash added a commit to plebhash/sv2-spec that referenced this pull request Oct 31, 2024
@plebhash
remove outdated reference to Job Declaration Protocol
d8b7d59 
companion to stratum-mining/stratum#1072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove JobDistributionProtocol from common_messages_sv2
3 participants
@Shourya742 @plebhash @GitGab19