test_diff_management: adjust total_run_time to 60s
#1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Sat, July 27, 2024 at 22:55:07 UTC |
| Project | Stratum v2 (SRI) |
| Branch | adjust-test-diff-management |
| Testbed | sv2 |
🚨 10 ALERTS: Threshold Boundary Limits exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| client_sv2_mining_message_submit_standard | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 26.00 (+46.07%) | 23.88 (108.88%) | |
| client_sv2_mining_message_submit_standard_serialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 55.00 (+15.63%) | 53.28 (103.23%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 10,585.00 (+0.39%) | 10,570.57 (100.14%) | |
| client_sv2_mining_message_submit_standard_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 15,400.00 (+0.38%) | 15,378.64 (100.14%) | |
| client_sv2_open_channel_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 8,027.00 (+0.52%) | 8,012.93 (100.18%) | |
| client_sv2_open_channel_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 11,673.00 (+0.49%) | 11,653.20 (100.17%) | |
| client_sv2_open_channel_serialize_deserialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 84.00 (+13.99%) | 83.14 (101.03%) | |
| client_sv2_setup_connection | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 15.00 (+61.45%) | 14.30 (104.91%) | |
| client_sv2_setup_connection_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 14,855.00 (+0.29%) | 14,840.35 (100.10%) | |
| client_sv2_setup_connection_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 21,812.00 (+0.27%) | 21,790.33 (100.10%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 2,077.00 (+1.30%) | 2,127.41 (97.63%) | ✅ (view plot) | 473.00 (+0.48%) | 486.30 (97.27%) | ✅ (view plot) | 732.00 (-0.02%) | 755.01 (96.95%) | ✅ (view plot) | 10.00 (+41.75%) | 11.00 (90.95%) | ✅ (view plot) | 37.00 (+0.94%) | 38.55 (95.99%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 8,219.00 (+0.26%) | 8,335.84 (98.60%) | ✅ (view plot) | 2,137.00 (+0.45%) | 2,171.21 (98.42%) | ✅ (view plot) | 3,159.00 (+0.45%) | 3,215.82 (98.23%) | ✅ (view plot) | 39.00 (+1.18%) | 43.57 (89.51%) | ✅ (view plot) | 139.00 (+0.10%) | 141.95 (97.92%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 6,282.00 (+0.10%) | 6,387.50 (98.35%) | ✅ (view plot) | 1,750.00 (+0.03%) | 1,763.06 (99.26%) | ✅ (view plot) | 2,547.00 (-0.26%) | 2,575.66 (98.89%) | 🚨 (view plot | view alert) | 26.00 (+46.07%) | 23.88 (108.88%) | ✅ (view plot) | 103.00 (-0.77%) | 106.87 (96.38%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14,623.00 (-0.99%) | 15,033.06 (97.27%) | ✅ (view plot) | 4,694.00 (+0.01%) | 4,707.06 (99.72%) | ✅ (view plot) | 6,753.00 (-0.02%) | 6,775.05 (99.67%) | 🚨 (view plot | view alert) | 55.00 (+15.63%) | 53.28 (103.23%) | ✅ (view plot) | 217.00 (-2.35%) | 230.01 (94.34%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27,435.00 (-0.15%) | 27,839.55 (98.55%) | 🚨 (view plot | view alert) | 10,585.00 (+0.39%) | 10,570.57 (100.14%) | 🚨 (view plot | view alert) | 15,400.00 (+0.38%) | 15,378.64 (100.14%) | ✅ (view plot) | 90.00 (+7.21%) | 90.04 (99.96%) | ✅ (view plot) | 331.00 (-1.10%) | 345.19 (95.89%) |
| client_sv2_open_channel | ✅ (view plot) | 4,417.00 (-1.61%) | 4,610.64 (95.80%) | ✅ (view plot) | 1,461.00 (+0.05%) | 1,474.33 (99.10%) | ✅ (view plot) | 2,157.00 (+0.19%) | 2,172.95 (99.27%) | ✅ (view plot) | 11.00 (-7.91%) | 15.19 (72.41%) | ✅ (view plot) | 63.00 (-3.16%) | 68.17 (92.41%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 14,006.00 (-1.43%) | 14,465.25 (96.83%) | ✅ (view plot) | 5,064.00 (+0.02%) | 5,077.33 (99.74%) | ✅ (view plot) | 7,321.00 (+0.04%) | 7,339.22 (99.75%) | ✅ (view plot) | 42.00 (+12.19%) | 42.48 (98.88%) | ✅ (view plot) | 185.00 (-3.43%) | 199.08 (92.93%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22,523.00 (-0.50%) | 23,019.37 (97.84%) | 🚨 (view plot | view alert) | 8,027.00 (+0.52%) | 8,012.93 (100.18%) | 🚨 (view plot | view alert) | 11,673.00 (+0.49%) | 11,653.20 (100.17%) | 🚨 (view plot | view alert) | 84.00 (+13.99%) | 83.14 (101.03%) | ✅ (view plot) | 298.00 (-2.08%) | 314.98 (94.61%) |
| client_sv2_setup_connection | ✅ (view plot) | 4,659.00 (-0.81%) | 4,764.55 (97.78%) | ✅ (view plot) | 1,502.00 (+0.05%) | 1,515.33 (99.12%) | ✅ (view plot) | 2,274.00 (-0.12%) | 2,299.44 (98.89%) | 🚨 (view plot | view alert) | 15.00 (+61.45%) | 14.30 (104.91%) | ✅ (view plot) | 66.00 (-2.68%) | 69.70 (94.69%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 15,942.00 (-1.92%) | 16,511.66 (96.55%) | ✅ (view plot) | 5,963.00 (+0.01%) | 5,976.33 (99.78%) | ✅ (view plot) | 8,662.00 (+0.08%) | 8,677.79 (99.82%) | ✅ (view plot) | 49.00 (+9.42%) | 49.40 (99.18%) | ✅ (view plot) | 201.00 (-4.60%) | 218.24 (92.10%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35,382.00 (-0.41%) | 35,748.34 (98.98%) | 🚨 (view plot | view alert) | 14,855.00 (+0.29%) | 14,840.35 (100.10%) | 🚨 (view plot | view alert) | 21,812.00 (+0.27%) | 21,790.33 (100.10%) | ✅ (view plot) | 110.00 (+10.00%) | 113.57 (96.85%) | ✅ (view plot) | 372.00 (-1.93%) | 385.11 (96.60%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Sat, July 27, 2024 at 22:55:09 UTC |
| Project | Stratum v2 (SRI) |
| Branch | adjust-test-diff-management |
| Testbed | sv2 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client_sv2_handle_message_common | ✅ (view plot) | 44.66 (+0.23%) | 45.24 (98.72%) |
| client_sv2_handle_message_mining | ✅ (view plot) | 72.69 (-0.38%) | 80.65 (90.13%) |
| client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.68 (+0.21%) | 14.69 (99.94%) |
| client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 265.47 (+0.40%) | 284.05 (93.46%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 590.57 (-0.61%) | 627.44 (94.12%) |
| client_sv2_open_channel | ✅ (view plot) | 167.04 (+0.61%) | 173.51 (96.27%) |
| client_sv2_open_channel_serialize | ✅ (view plot) | 273.31 (-3.32%) | 293.84 (93.01%) |
| client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 379.39 (+0.27%) | 423.49 (89.59%) |
| client_sv2_setup_connection | ✅ (view plot) | 165.85 (+1.03%) | 174.81 (94.87%) |
| client_sv2_setup_connection_serialize | ✅ (view plot) | 454.67 (-4.16%) | 507.43 (89.60%) |
| client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 1,020.10 (+4.99%) | 1,040.63 (98.03%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Sat, July 27, 2024 at 22:55:09 UTC |
| Project | Stratum v2 (SRI) |
| Branch | adjust-test-diff-management |
| Testbed | sv1 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
| Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
|---|---|---|---|---|---|
| serialize_deserialize_handle_authorize | RAM Accesses (accesses) | 🚨 (view plot | view alert) | 369.00 (+1.38%) | 367.55 (100.39%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | ✅ (view plot) | 8,507.00 (+0.83%) | 8,724.75 (97.50%) | ✅ (view plot) | 3,749.00 (+0.23%) | 3,854.80 (97.26%) | ✅ (view plot) | 5,252.00 (+0.13%) | 5,400.78 (97.25%) | ✅ (view plot) | 7.00 (-11.71%) | 10.37 (67.47%) | ✅ (view plot) | 92.00 (+2.14%) | 94.06 (97.81%) |
| get_submit | ✅ (view plot) | 95,478.00 (-0.08%) | 96,137.02 (99.31%) | ✅ (view plot) | 59,442.00 (-0.05%) | 59,776.34 (99.44%) | ✅ (view plot) | 85,363.00 (-0.05%) | 85,833.35 (99.45%) | ✅ (view plot) | 49.00 (-10.91%) | 62.60 (78.28%) | ✅ (view plot) | 282.00 (-0.03%) | 287.66 (98.03%) |
| get_subscribe | ✅ (view plot) | 7,960.00 (-0.21%) | 8,268.30 (96.27%) | ✅ (view plot) | 2,844.00 (+0.49%) | 2,939.40 (96.75%) | ✅ (view plot) | 3,975.00 (+0.53%) | 4,099.10 (96.97%) | ✅ (view plot) | 13.00 (-19.38%) | 19.83 (65.54%) | ✅ (view plot) | 112.00 (-0.55%) | 116.90 (95.81%) |
| serialize_authorize | ✅ (view plot) | 12,260.00 (+0.43%) | 12,502.46 (98.06%) | ✅ (view plot) | 5,320.00 (+0.16%) | 5,425.80 (98.05%) | ✅ (view plot) | 7,415.00 (+0.10%) | 7,564.12 (98.03%) | ✅ (view plot) | 10.00 (-7.28%) | 13.35 (74.89%) | ✅ (view plot) | 137.00 (+1.04%) | 140.24 (97.69%) |
| serialize_deserialize_authorize | ✅ (view plot) | 24,557.00 (+0.35%) | 24,710.01 (99.38%) | ✅ (view plot) | 9,901.00 (+0.01%) | 10,025.50 (98.76%) | ✅ (view plot) | 13,962.00 (-0.03%) | 14,149.95 (98.67%) | ✅ (view plot) | 33.00 (-9.63%) | 41.61 (79.31%) | ✅ (view plot) | 298.00 (+1.04%) | 298.00 (100.00%) |
| serialize_deserialize_handle_authorize | ✅ (view plot) | 30,338.00 (+0.62%) | 30,353.94 (99.95%) | ✅ (view plot) | 12,104.00 (+0.07%) | 12,209.80 (99.13%) | ✅ (view plot) | 17,118.00 (+0.00%) | 17,279.06 (99.07%) | ✅ (view plot) | 61.00 (+3.70%) | 64.72 (94.25%) | 🚨 (view plot | view alert) | 369.00 (+1.38%) | 367.55 (100.39%) |
| serialize_deserialize_handle_submit | ✅ (view plot) | 126,406.00 (-0.00%) | 127,027.26 (99.51%) | ✅ (view plot) | 73,224.00 (-0.04%) | 73,617.68 (99.47%) | ✅ (view plot) | 104,946.00 (-0.04%) | 105,508.30 (99.47%) | ✅ (view plot) | 120.00 (-0.41%) | 131.20 (91.46%) | ✅ (view plot) | 596.00 (+0.19%) | 599.20 (99.47%) |
| serialize_deserialize_handle_subscribe | ✅ (view plot) | 27,506.00 (+0.18%) | 27,601.91 (99.65%) | ✅ (view plot) | 9,646.00 (+0.14%) | 9,741.40 (99.02%) | ✅ (view plot) | 13,641.00 (+0.13%) | 13,774.95 (99.03%) | ✅ (view plot) | 64.00 (-2.79%) | 73.76 (86.77%) | ✅ (view plot) | 387.00 (+0.31%) | 388.57 (99.60%) |
| serialize_deserialize_submit | ✅ (view plot) | 114,999.00 (-0.07%) | 115,648.79 (99.44%) | ✅ (view plot) | 68,001.00 (-0.08%) | 68,400.22 (99.42%) | ✅ (view plot) | 97,559.00 (-0.09%) | 98,146.90 (99.40%) | ✅ (view plot) | 65.00 (-6.28%) | 75.30 (86.32%) | ✅ (view plot) | 489.00 (+0.18%) | 492.37 (99.32%) |
| serialize_deserialize_subscribe | ✅ (view plot) | 22,891.00 (+0.07%) | 23,110.09 (99.05%) | ✅ (view plot) | 8,198.00 (+0.15%) | 8,297.07 (98.81%) | ✅ (view plot) | 11,546.00 (+0.14%) | 11,682.23 (98.83%) | ✅ (view plot) | 36.00 (-8.49%) | 44.08 (81.67%) | ✅ (view plot) | 319.00 (+0.15%) | 321.48 (99.23%) |
| serialize_submit | ✅ (view plot) | 99,795.00 (-0.10%) | 100,465.25 (99.33%) | ✅ (view plot) | 61,486.00 (-0.05%) | 61,825.69 (99.45%) | ✅ (view plot) | 88,210.00 (-0.05%) | 88,686.84 (99.46%) | ✅ (view plot) | 49.00 (-11.85%) | 62.38 (78.55%) | ✅ (view plot) | 324.00 (-0.20%) | 329.15 (98.44%) |
| serialize_subscribe | ✅ (view plot) | 11,297.00 (-0.26%) | 11,604.19 (97.35%) | ✅ (view plot) | 4,191.00 (+0.33%) | 4,286.40 (97.77%) | ✅ (view plot) | 5,832.00 (+0.34%) | 5,958.28 (97.88%) | ✅ (view plot) | 15.00 (-8.20%) | 18.95 (79.14%) | ✅ (view plot) | 154.00 (-0.77%) | 159.72 (96.42%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
| Report | Sat, July 27, 2024 at 22:55:08 UTC |
| Project | Stratum v2 (SRI) |
| Branch | 1075/merge |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|
| client-submit-serialize | ✅ (view plot) | 6,453.40 (-6.68%) | 7,365.07 (87.62%) |
| client-submit-serialize-deserialize | ✅ (view plot) | 7,493.50 (-4.43%) | 8,325.60 (90.01%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 8,036.20 (-4.41%) | 8,843.12 (90.88%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 893.49 (-0.50%) | 926.25 (96.46%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 706.15 (+1.27%) | 718.09 (98.34%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 248.29 (+0.10%) | 255.10 (97.33%) |
| client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 159.23 (+1.31%) | 162.47 (98.01%) |
| client-sv1-get-submit | ✅ (view plot) | 6,250.00 (-6.43%) | 7,157.06 (87.33%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 281.40 (+0.97%) | 291.19 (96.64%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 773.52 (+3.42%) | 778.09 (99.41%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 611.63 (-0.43%) | 637.31 (95.97%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 206.46 (-0.05%) | 219.82 (93.92%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
plebhash
changed the title
test_diff_management: adjust total_run_time 60stest_diff_management: adjust total_run_time to 60s
plebhash
force-pushed
the
adjust-test-diff-management
branch
from
6e56e59
to
3622764
Compare
jbesraa
approved these changes
Jul 29, 2024
Fi3
approved these changes
Jul 29, 2024
GitGab19
approved these changes
Jul 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we made some adjustments to
test_diff_managementvia #995 , which unfortunately did not fully fix #988both @Fi3 and I did some investigation on this:
test_diff_managementtest #995 (comment)downstream_sv1::diff_management::test::test_diff_management#988 (comment)in summary, bigger values for
total_run_timeseems to always improve things, so this PR adjusts it to 60s in hope it will fix this once and for allif we have to re-open #988 again after this is merged, then we should consider #1074 , which completely disables
test_diff_managementuntil a more sustainable fix is found