queryCatalog.py filters out False boolean value

[puittenbroek]

Steps to reproduce:

Make a new Plone site
Insert following scipts via ZMI into custom

qry = {'is_default_page': False, 'path': {'query':context.getPhysicalPath(), 'depth':1}}
print "Query: {}".format(qry)
query_results = context.getFolderContents(qry)

print "\n\ngetFolderContents results:"
print [x.id for x in query_results]


pc_results = context.portal_catalog(**qry)
print "\n\nportal_catalog results:"
print [x.id for x in pc_results]

return printed

And run it, result is:

Query: {'path': {'query': ('', 'Plone'), 'depth': 1}, 'is_default_page': False}


getFolderContents results:
['front-page', 'news', 'events', 'Members']


portal_catalog results:
['news', 'events', 'Members']   

Expected results is that both lists are the same. But in queryCatalog.y it does the following:

for k in REQUEST.keys():
    if k in ('SESSION',):
        continue
    v = REQUEST.get(k)
    if v and k in indexes:

Which means that any value that is a pythonic False gets filtered out, including an actual False.
This is present in 4.3.3 and also master branch here on github.

[ale-rt]

This is still an issue for Plone 6.

I adapted the script:

qry = {'is_default_page': False, 'path': {'query': "/".join(context.getPhysicalPath()), 'depth':1}}
print("Query: {}".format(qry))
query_results = context.getFolderContents(qry)

print("\n\ngetFolderContents results:")
print([x.id for x in query_results])

pc_results = context.portal_catalog(**qry)
print("\n\nportal_catalog results:")
print([x.id for x in pc_results])

return printed

Created a folder with a default page on https://6-classic.demo.plone.org/ and ran it:

Query: {'is_default_page': False, 'path': {'query': '/Plone/en/demo/folder-with-default-page', 'depth': 1}}

getFolderContents results:
['default-page-for-folder']


portal_catalog results:
[]

[jensens]

this script will be removed in Plone 6.1