list of plone_scripts to get rid of #1801

jensens · 2016-10-21T03:16:32Z

I just checked the state of skins/plone_scripts and it looks there are some low hanging fruits around.

[Checked for Plone 6.0 on 2022-08-24]

various places, needs detailed check

The text was updated successfully, but these errors were encountered:

jensens · 2016-10-21T03:27:40Z

see also #1802

… its skins folder. ref #1801

…- plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801

…- plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801 removing records (wip) remove jquery-highlightsearchterms from the plone-legacy bundle c

… its skins folder. ref #1801

Branch: refs/heads/master Date: 2018-09-06T18:21:00+02:00 Author: Sune Broendum Woeller (sunew) <sune@woeller.dk> Commit: plone/plone.app.upgrade@6bab181 remove the jquery-highlightsearchterms resource, and the - now empty - plone_ecmascript skin layer. See https://github.com/plone/Products.CMFPlone/pull/1963/commits and plone/Products.CMFPlone#1811 plone/Products.CMFPlone#1801 removing records (wip) remove jquery-highlightsearchterms from the plone-legacy bundle c Files changed: A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml M CHANGES.rst M plone/app/upgrade/v52/alphas.py M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2018-09-06T20:23:08+02:00 Author: Sune Broendum Woeller (sunew) <sune@woeller.dk> Commit: plone/plone.app.upgrade@c979968 Also remove the jquery-highlightsearchterms resource, and the plone_ecmascript skin layer for plone 5.1.4 Files changed: A plone/app/upgrade/v51/profiles/to_514/skins.xml M CHANGES.rst M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/final.py M plone/app/upgrade/v51/profiles/to_514/registry.xml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2018-09-08T12:26:59+02:00 Author: Sune Broendum Woeller (sunew) <sune@woeller.dk> Commit: plone/plone.app.upgrade@0c1c1ee Update the compilation date of the plone-legacy bundle, to force recompilation Files changed: M plone/app/upgrade/v51/profiles/to_514/registry.xml M plone/app/upgrade/v52/profiles/to_alpha1/registry.xml Repository: plone.app.upgrade Branch: refs/heads/master Date: 2018-09-09T08:41:13+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.upgrade@8d8f25d Merge pull request #170 from plone/remove-highlightsearchterms Remove jquery-highlightsearchterms and plone_ecmascript layer Files changed: A plone/app/upgrade/v51/profiles/to_514/skins.xml A plone/app/upgrade/v52/profiles/to_alpha1/registry.xml M CHANGES.rst M plone/app/upgrade/v51/configure.zcml M plone/app/upgrade/v51/final.py M plone/app/upgrade/v51/profiles/to_514/registry.xml M plone/app/upgrade/v52/alphas.py M plone/app/upgrade/v52/profiles/to_alpha1/skins.xml

… its skins folder. ref #1801

Branch: refs/heads/master Date: 2018-10-02T18:09:50+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.blob@130d380 Removed usage of getObjSize script from tests. Also declared dependency on Products.CMFPlone. plone/Products.CMFPlone#1801 Files changed: M setup.py M src/plone/app/blob/tests/test_replacements.py Repository: plone.app.blob Branch: refs/heads/master Date: 2018-10-02T18:14:23+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.blob@dfaf548 Added changelog entry. Files changed: M CHANGES.rst Repository: plone.app.blob Branch: refs/heads/master Date: 2018-10-05T20:16:16+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.blob@4de7add Merge pull request #52 from plone/1801-get-size Removed usage of getObjSize script from tests. Files changed: M CHANGES.rst M setup.py M src/plone/app/blob/tests/test_replacements.py

Branch: refs/heads/master Date: 2018-10-05T12:02:57+02:00 Author: Manuel Reinhardt (reinhardt) <reinhardt@syslab.com> Commit: plone/plone.app.content@738b89b Replaced another usage of getObjSize. plone/Products.CMFPlone#1801 Files changed: M plone/app/content/browser/content_status_history.py M plone/app/content/browser/templates/content_status_history.pt Repository: plone.app.content Branch: refs/heads/master Date: 2018-10-05T20:17:18+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.content@6031bad Merge pull request #169 from plone/1801-get-size-part-2 Replaced another usage of getObjSize Files changed: M plone/app/content/browser/content_status_history.py M plone/app/content/browser/templates/content_status_history.pt

mauritsvanrees · 2018-10-22T19:51:15Z

Status as of 22 October 2018: 12 scripts to go in Products.CMFPlone/skins/plone_scripts:

browserDefault.py
externalEditorEnabled.py
external_edit.py
folder_publish.cpy
generateUniqueId.py
getFolderContents.py
pretty_title_or_id.py
queryCatalog.py
toLocalizedTime.py
translate.py
unique.py
utranslate.py

(The list in the main text of this issue is leading.)

pbauer · 2019-04-15T18:03:52Z

Also content_status_modify from plone_form_scripts

jensens · 2019-04-16T08:21:11Z

added to the list

fulv · 2019-04-18T10:42:31Z

Shouldn't these be at least replaced with a stub view with a deprecation message, or something telling people what they should use instead? I just stumbled over a missing getObjSize,and it was pretty baffling at first. -- Fulvio

…

On Tue, Apr 16, 2019 at 10:21 AM Jens W. Klein ***@***.***> wrote: added to the list — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1801 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAcHxu3sJmmrVaqCXLbtjclmZD6Jh1KQks5vhYf4gaJpZM4Kc0ey> .

Actually, it might be possible to delete the enable_compression method entirely, it doesn't seem to be used by Plone. I'm just not sure whether 3rd-party code might rely on it even though I think it's unlikely.

re #1801: Remove enable_compression while removing skin script.

jensens · 2023-03-13T10:45:16Z

The scripts are still there in Plone 6. It is a task for Plone 6.1 to remove them all.

gforcada · 2023-03-13T11:34:08Z

Some of them, might be refactored and moved to plone.base, or? 🤔

jensens · 2023-03-13T13:14:54Z

I think most of these scripts already have alternatives. Just that they are not used in the code.

gforcada · 2023-03-13T13:54:56Z

Oh, that's even better, if we get a mapping, then creating the fixing code should be relatively easy to do 👍🏾

Even better if we post it on community.plone.org so a GSOC student picks it up so s/he proofs her/himself 😄

mauritsvanrees · 2023-03-13T14:33:18Z

Let me paste the link to the plone_scripts folder:

https://github.com/plone/Products.CMFPlone/tree/master/Products/CMFPlone/skins/plone_scripts

jensens added 04 type: enhancement 14 prio: low 22 status: in-progress labels Oct 21, 2016

jensens mentioned this issue Oct 22, 2016

Get rid of plone scripts 2 #1807

Merged

jensens added 31 needs: help 42 lvl: moderate labels Oct 23, 2016

This was referenced Oct 27, 2016

Move script date_components_support.py to Archetypes #1816

Merged

moved script date_components_support.py from CMFPlone over here plone/Products.Archetypes#68

Merged

jensens added a commit that referenced this issue Mar 9, 2017

fix #1811: Remove last legacy Javascript highlight-searchterms.js and…

8b1c87a

… its skins folder. ref #1801

jensens mentioned this issue Mar 9, 2017

fix #1811: Remove last legacy Javascript highlight-searchterms.js #1963

Merged

4 tasks

jensens added a commit that referenced this issue Mar 9, 2017

fix #1811: Remove last legacy Javascript highlight-searchterms.js and…

598d92e

… its skins folder. ref #1801

agitator mentioned this issue Jun 18, 2018

Remove unused mail_password.py from skins/plone_scripts #2444

Merged

jensens added a commit that referenced this issue Aug 13, 2018

fix #1811: Remove last legacy Javascript highlight-searchterms.js and…

67c3e67

… its skins folder. ref #1801

sunew mentioned this issue Sep 6, 2018

Remove jquery-highlightsearchterms and plone_ecmascript layer plone/plone.app.upgrade#170

Merged

sunew pushed a commit that referenced this issue Sep 6, 2018

fix #1811: Remove last legacy Javascript highlight-searchterms.js and…

88ff082

… its skins folder. ref #1801

This was referenced Sep 6, 2018

Backport remove highlightsearchterms (wrong merge base) #2508

Closed

Backport remove highlightsearchterms #2509

Merged

erral pushed a commit that referenced this issue Sep 14, 2018

fix #1811: Remove last legacy Javascript highlight-searchterms.js and…

3e1f7c1

… its skins folder. ref #1801

ksuess self-assigned this Oct 1, 2018

reinhardt mentioned this issue Oct 1, 2018

Fix DX document size for Python 3 #2538

Merged

reinhardt self-assigned this Oct 1, 2018

reinhardt added a commit that referenced this issue Oct 1, 2018

Factored out format_size method for replacing getObjSize.py. #1801

072dba9

reinhardt mentioned this issue Oct 1, 2018

Factored out human_readable_size method for replacing getObjSize.py #2544

Merged

reinhardt added a commit that referenced this issue Oct 2, 2018

Moved format_size to utils and renamed to human_readable_size. #1801

4faf030

This was referenced Oct 5, 2018

Skin scripts will be removed plone/Products.CMFEditions#60

Closed

Added utils.human_readable_size. #2578

Merged

mauritsvanrees mentioned this issue Oct 5, 2018

Use new utils.check_id from CMFPlone plone/Products.ATContentTypes#60

Closed

2 tasks

ale-rt pushed a commit that referenced this issue Oct 15, 2018

Removed isExpired.py skin script. #1801 (#2570)

042eb21

jensens mentioned this issue Oct 23, 2018

Removed generateUniqueId.py skins script #2600

Merged

reinhardt removed their assignment Nov 15, 2018

gforcada mentioned this issue Jan 1, 2019

feat: remove Products.CMFFormController #2680

Closed

mauritsvanrees mentioned this issue Feb 26, 2020

Remove all form controller scripts #3057

Closed

ksuess removed their assignment Mar 19, 2020

jensens pushed a commit that referenced this issue Nov 12, 2021

re #1801: remove enable_compression completely as it isn't used in Plone

4420a7a

jensens pushed a commit that referenced this issue Nov 12, 2021

Merge pull request #163 from plone/1801-remove-enableHTTPCompression

ab97cb1

re #1801: Remove enable_compression while removing skin script.

jensens added this to the Plone 6.1 milestone Mar 13, 2023

This was referenced May 16, 2024

Remove all skin layers in Plone 6 #3515

Open

Remove queryCatalog and getFolderContents skin scripts #3960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

list of plone_scripts to get rid of #1801

list of plone_scripts to get rid of #1801

jensens commented Oct 21, 2016 •

edited

Loading

jensens commented Oct 21, 2016

mauritsvanrees commented Oct 22, 2018

pbauer commented Apr 15, 2019

jensens commented Apr 16, 2019

fulv commented Apr 18, 2019 via email

jensens commented Mar 13, 2023

gforcada commented Mar 13, 2023

jensens commented Mar 13, 2023

gforcada commented Mar 13, 2023

mauritsvanrees commented Mar 13, 2023

list of plone_scripts to get rid of #1801

list of plone_scripts to get rid of #1801

Comments

jensens commented Oct 21, 2016 • edited Loading

jensens commented Oct 21, 2016

mauritsvanrees commented Oct 22, 2018

pbauer commented Apr 15, 2019

jensens commented Apr 16, 2019

fulv commented Apr 18, 2019 via email

jensens commented Mar 13, 2023

gforcada commented Mar 13, 2023

jensens commented Mar 13, 2023

gforcada commented Mar 13, 2023

mauritsvanrees commented Mar 13, 2023

jensens commented Oct 21, 2016 •

edited

Loading