Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove queryCatalog and getFolderContents skin scripts #3960

Merged
merged 3 commits into from
May 17, 2024
Merged

Remove queryCatalog and getFolderContents skin scripts #3960

merged 3 commits into from
May 17, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented May 16, 2024

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens changed the title remove queryCatalog script. remove queryCatalog skin script. May 16, 2024
@jensens jensens force-pushed the rm-queryCatalog branch from 5f7ec94 to 637e886 Compare May 16, 2024 19:13
@jensens jensens marked this pull request as ready for review May 16, 2024 19:13
@jensens jensens mentioned this pull request May 16, 2024
Merged
@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@jensens jensens mentioned this pull request May 16, 2024
Merged
@jensens jensens changed the title remove queryCatalog skin script. Remove queryCatalog and getFolderContents skin scripts May 16, 2024
@jensens
Copy link
Member Author

jensens commented May 16, 2024

First merge plone/plone.app.content#281
then this one.

@jensens
Copy link
Member Author

jensens commented May 16, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Member Author

jensens commented May 16, 2024

check fields in #1801 when finished

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@jensens jensens mentioned this pull request May 17, 2024
Merged
@jensens jensens force-pushed the rm-queryCatalog branch from 33216e9 to f72a1b0 Compare May 17, 2024 08:01
@jensens
Copy link
Member Author

jensens commented May 17, 2024

@jenkins-plone-org please run jobs

@jensens jensens force-pushed the rm-queryCatalog branch from f72a1b0 to d042363 Compare May 17, 2024 08:04
@jensens
Copy link
Member Author

jensens commented May 17, 2024

@jenkins-plone-org please run jobs

@jensens jensens force-pushed the rm-queryCatalog branch from d042363 to 5570553 Compare May 17, 2024 08:57
@jensens
Copy link
Member Author

jensens commented May 17, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Member Author

jensens commented May 17, 2024

@jenkins-plone-org please run jobs

@jensens jensens merged commit 7d6f1ed into master May 17, 2024
4 checks passed
@jensens jensens deleted the rm-queryCatalog branch May 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurj yurj yurj left review comments

Assignees
No one assigned
Labels
04 type: enhancement 14 prio: low 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jensens @mister-roboto @davisagli @yurj