feat: remove Products.CMFFormController #2680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauritsvanrees
requested changes
Dec 31, 2018
There was a problem hiding this comment.
LGTM, but I see a mention of portal_form_controller in the tests that could be removed too:
https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/tests/test_zmi.py#L104-L107
|
Well, I said 'looks good to me', but I didn't yet notice that there were many test failures. Seems we are not completely independent of CMFFormController yet. |
|
After a closer look at the errors, it looks like we first need to clean up all the scripts on On python2, as archetypes is there, makes things a tad more complicated 😖 |
Only a few traces were still left, most importantly on setup.py.
gforcada
force-pushed
the
gforcada-remove-cmfformcontroller
branch
from
0f49555 to
a5c29ea
Compare
|
@jenkins-plone-org please run jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a few traces were still left, most importantly on setup.py.
Fixes #448