Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLIP 2454 DX Plone Site #2612

Merged
merged 190 commits into from
Sep 11, 2021
Merged

PLIP 2454 DX Plone Site #2612

merged 190 commits into from
Sep 11, 2021

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Nov 2, 2018 •
edited
Loading

See #2454

jaroel added 14 commits November 2, 2018 08:51
@jaroel
DX based Plone Site
778d541
@jaroel
Use /@@edit as /edit doesn't work
1dbbebe 
Need to figure out why it is a 204.
@jaroel
Fix a bunch of tests
d44f2d5
@jaroel
DX uses zExceptions's Unauthorized, not AccessControl's
aaeda50
@jaroel
Fix method aliasses
26b2f74
@jaroel
Aliasses work again
56ee59a
@jaroel
Plone Site's FTI did actually change
3d7db01
@jaroel
Short circuit empty name in __getattr__
e7c7f0c
@jaroel
PROPFIND is an acceptable method.
cb0bd89
@jaroel
Remove index_html from skins. We use the DX container default view in…
df2b462 
…stead.
@jaroel
Remove index_html for Portal class. We’ll use the DX variant instead.
c7925bd
@jaroel
Make Plone Site a navigation root. This enabled the dashboard view
72cfb21
@jaroel
We need INavigationRoot earlier in the IRO, or we'll get the dashboar…
f60a93b 
…d namespace traverser.
@jaroel
Wait a bit until the elements are visible
85f8eab
@jaroel jaroel self-assigned this Nov 2, 2018
@jaroel jaroel mentioned this pull request Feb 16, 2019
Closed
@jaroel jaroel force-pushed the dx-siteroot-master branch from 31b0f83 to c897100 Compare March 5, 2019 14:32
ale-rt and others added 19 commits December 12, 2020 17:49
@ale-rt
Revert "Revert "Move custom __set_attr__ previously found in the dext…
c74c287 
…erity branch""

This reverts commit f9d3971.
@ale-rt
Remove the old object before setting the new one to prevent a duplica…
9e16678 
…te id error
@jaroel
Merge remote-tracking branch 'origin/master' into dx-siteroot-master
fc169dd
@ale-rt
Merge branch 'master' into dx-siteroot-master
797ab44
@ale-rt
Order import and fix the ZMI
a213147
@ale-rt
Revert "all a-ok"
c1ed6e9 
This reverts commit 43ba60a.
@ale-rt
Remove versioning bahavior
7da164c
@ale-rt
Fix the Portal object
8e075a4
@ale-rt
Backport a patch on Zope
1dd006a
@ale-rt
Fix delattr
d30c187
@ale-rt
Remove permission that seems not needed
f23a069
@ale-rt
Restore custom setattr and remove PORTAL_SKINS_TOOL_ID
56bb72f
@ale-rt
This is already in Zope master
4868487
@ale-rt
Fix migration when we have broken objects in the Zope app root and when
d15fdfc 
the site is still not migrated to dexterity

Refs #3245
@ale-rt
Merge remote-tracking branch 'origin/master' into dx-siteroot-master
f2493ea
@esteele
Merge branch 'master' into dx-siteroot-master
a1c39bf
@ale-rt
Merge remote-tracking branch 'origin/master' into dx-siteroot-master
ea4ce6f
@mauritsvanrees
Merge branch 'master' into dx-siteroot-master
9c2f767
@mauritsvanrees
Add news snippet
3ed79d3
mauritsvanrees
mauritsvanrees approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

tisto
tisto approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did not do an in-depth review of the code though.

@ale-rt
Copy link
Member

ale-rt commented Sep 7, 2021

I started the jenkin jobs using the following parameters:

https://github.com/plone/Products.CMFPlone/pull/2612
https://github.com/plone/plone.app.contenttypes/pull/475
https://github.com/plone/plone.app.upgrade/pull/256

@ale-rt ale-rt mentioned this pull request Sep 7, 2021
Merged
@mauritsvanrees mauritsvanrees merged commit 06db2c5 into master Sep 11, 2021
@avoinea avoinea deleted the dx-siteroot-master branch September 13, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto tisto approved these changes

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees

@jaroel jaroel

Labels
03 type: feature (plip)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.