-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use behavior-names instead of python-paths in types-controlpanel #3294
Conversation
@pbauer thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
This breaks two related robot tests that probably still expect the old names somewhere. |
+1 for the change - just tests needs fixing as well. |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
tests are fixed but |
I think this is an error in the |
If the PR was created before the Python 3.6 job was removed the check will stick forever. This was the case also for #2612. If you really want to run it you still can:
If it fails the PR will still be good for being merged if the other checks are green :) |
Well also new PRs have the Python 3.6 job... I added an issue: #3318 |
@jenkins-plone-org please run jobs |
1 similar comment
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
No description provided.