Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use behavior-names instead of python-paths in types-controlpanel #3294

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Jul 28, 2021

No description provided.

@mister-roboto
Copy link

@pbauer thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@pbauer
Copy link
Member Author

pbauer commented Jul 28, 2021

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member

This breaks two related robot tests that probably still expect the old names somewhere.

@jensens
Copy link
Member

jensens commented Jul 29, 2021

+1 for the change - just tests needs fixing as well.

@petschki
Copy link
Member

petschki commented Sep 7, 2021

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

petschki commented Sep 7, 2021

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

petschki commented Sep 7, 2021

tests are fixed but pull-request-6.0-3.6 doesn't exist on jenkins.plone.org but is required here ... @mauritsvanrees @pbauer why that?

@mauritsvanrees
Copy link
Member

tests are fixed but pull-request-6.0-3.6 doesn't exist on jenkins.plone.org but is required here ... @mauritsvanrees @pbauer why that?

I think this is an error in the mr.roboto config on the Jenkins server. Originally we tested 6.0 on 3.6 but not anymore.
@fredvd Can you check the config on the server?

@ale-rt
Copy link
Member

ale-rt commented Sep 7, 2021

If the PR was created before the Python 3.6 job was removed the check will stick forever.

This was the case also for #2612.

If you really want to run it you still can:

If it fails the PR will still be good for being merged if the other checks are green :)

@ale-rt
Copy link
Member

ale-rt commented Sep 15, 2021

Well also new PRs have the Python 3.6 job... I added an issue: #3318

@petschki
Copy link
Member

@jenkins-plone-org please run jobs

1 similar comment
@thet
Copy link
Member

thet commented Oct 7, 2021

@jenkins-plone-org please run jobs

@pbauer
Copy link
Member Author

pbauer commented Mar 31, 2022

@jenkins-plone-org please run jobs

@pbauer pbauer merged commit 1f09a85 into master Mar 31, 2022
@pbauer pbauer deleted the use-behavior-names branch March 31, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants