-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plone.app.caching to list of add-ons to upgrade #3311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grading Plone. In PR plone/plone.app.caching#83 I add the first upgrade step.
@jenkins-plone-org please run jobs |
ale-rt
approved these changes
Sep 13, 2021
jensens
requested changes
Sep 13, 2021
CMFPlacefulWorkflow, plone.app.caching, and plone.app.iterate are not dependencies of CMFPlone, but of Plone, so not all sites will have them. This avoids a GenericSetup warning. See #3311 (comment)
…terate. This package at the moment still has a profile called plone.app.iterate. In 3.1.5 (used since Plone 5.0.3), the default profile was added. The old name is kept for compatibility until now, but should be removed. Perhaps this may need an upgrade step in plone.app.iterate for people who used the old name. But with the old name in the addon list, `plone.app.iterate:default` was never upgraded automatically.
@jenkins-plone-org please run jobs |
jensens
approved these changes
Sep 14, 2021
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Sep 14, 2021
Branch: refs/heads/master Date: 2021-09-13T12:20:58+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@b9db2df Add plone.app.caching to the list of add-ons that is upgraded when upgrading Plone. In PR plone/plone.app.caching#83 I add the first upgrade step. Files changed: A news/82.bugfix M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-13T20:01:52+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@85c4e7c Addon list for upgrade: check if we can import non-standard packages. CMFPlacefulWorkflow, plone.app.caching, and plone.app.iterate are not dependencies of CMFPlone, but of Plone, so not all sites will have them. This avoids a GenericSetup warning. See plone/Products.CMFPlone#3311 (comment) Files changed: M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-13T20:02:55+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@1128832 Addon list for upgrade: try to upgrade default profile of plone.app.iterate. This package at the moment still has a profile called plone.app.iterate. In 3.1.5 (used since Plone 5.0.3), the default profile was added. The old name is kept for compatibility until now, but should be removed. Perhaps this may need an upgrade step in plone.app.iterate for people who used the old name. But with the old name in the addon list, `plone.app.iterate:default` was never upgraded automatically. Files changed: M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-14T09:09:43+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/Products.CMFPlone@3227b15 Merge pull request #3311 from plone/maurits/plone-app-caching-in-addon-list Add plone.app.caching to list of add-ons to upgrade Files changed: A news/82.bugfix M Products/CMFPlone/MigrationTool.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This list gets upgraded when calling
@@upgrade-plone
.In PR plone/plone.app.caching#83 I add the first upgrade step.