Add upgrade step for terse caching #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general settings remain in registry.xml. Weak, moderate, strong, terse, and generic get their own file in the registry directory. (Generic is not used by default, it was commented out in the original.) This should give a better overview. Also, this makes it easier to copy `registry/terse.xml` for an upgrade step.
Fixes #82 Note: to let this be automatically applied when running @@plone-upgrade, we should add it to the AddOn list in CMFPlone/MigrationTool.py. I will do that part next, but this can be done separately.
|
@mauritsvanrees thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
added a commit
to plone/Products.CMFPlone
that referenced
this pull request
Sep 13, 2021
…grading Plone. In PR plone/plone.app.caching#83 I add the first upgrade step.
|
Be aware: plone.app.caching is part of package |
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this pull request
Sep 14, 2021
Branch: refs/heads/master Date: 2021-09-13T12:20:58+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@b9db2df Add plone.app.caching to the list of add-ons that is upgraded when upgrading Plone. In PR plone/plone.app.caching#83 I add the first upgrade step. Files changed: A news/82.bugfix M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-13T20:01:52+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@85c4e7c Addon list for upgrade: check if we can import non-standard packages. CMFPlacefulWorkflow, plone.app.caching, and plone.app.iterate are not dependencies of CMFPlone, but of Plone, so not all sites will have them. This avoids a GenericSetup warning. See plone/Products.CMFPlone#3311 (comment) Files changed: M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-13T20:02:55+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@1128832 Addon list for upgrade: try to upgrade default profile of plone.app.iterate. This package at the moment still has a profile called plone.app.iterate. In 3.1.5 (used since Plone 5.0.3), the default profile was added. The old name is kept for compatibility until now, but should be removed. Perhaps this may need an upgrade step in plone.app.iterate for people who used the old name. But with the old name in the addon list, `plone.app.iterate:default` was never upgraded automatically. Files changed: M Products/CMFPlone/MigrationTool.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2021-09-14T09:09:43+02:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/Products.CMFPlone@3227b15 Merge pull request #3311 from plone/maurits/plone-app-caching-in-addon-list Add plone.app.caching to list of add-ons to upgrade Files changed: A news/82.bugfix M Products/CMFPlone/MigrationTool.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #82
Note: to let this be automatically applied when running
@@plone-upgrade, we should add it to the AddOn list inCMFPlone/MigrationTool.py. I will do that part next, but this can be done and tested separately. It is good to have the upgrade step available.Alternatively, we could add an upgrade step in
plone.app.upgrade. But we would likely only run this upgrade step in Plone 6. That would mean the upgrade step is missing for users of Plone 5.2 Python 3 who know what they are doing and want to use this new version.Hint for reviewers: this PR is probably easiest to review by looking at the individual commits. The first two commits are stepping stones to make the third commit easier.