-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plip10359 security controlpanel fixes #362
Conversation
When "use_email_as_login" setting is enabled, "E-mail" is displayed instead of "Login Name" on the login form. This is now working correctly due to the previous commit.
When "use_email_as_login" setting is enabled, "My email address is" is displayed instead of "My user name is".
We are testing on the search view, since author info currently appears only on search and listing views, not on document view etc.. See also #337.
Added a list of pull requests, which should be merged along with this one. The tests are passing on my local machine, except I'm getting
These errors don't seem to be related to my changes, can you please take a look if it works for you, @tisto or @khink ? Here is the buildout for the security panel migration: plone/buildout.coredev#61 Otherwise it should be good to merge. Thanks! |
Which of the packages above should retain Plone 4 support? So we'd need to do something like: plone/plone.app.contenttypes@2347905 |
Conflicts: CHANGES.rst Products/CMFPlone/skins/plone_templates/default_error_message.pt
…o plip10359-security-controlpanel Conflicts: CHANGES.rst
Plip10359 security controlpanel fixes
This is a pull request for #216 . Most of the work was already merged previously, here it's mostly cleanup stuff:
There are also fixes in a number of other packages, which should be merged along with this PR, please wait with the merge until I add the list of other pull requests here.