Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plip10359 security controlpanel fixes #362

Merged
merged 12 commits into from
Mar 2, 2015
Merged

Conversation

jcerjak
Copy link
Member

@jcerjak jcerjak commented Jan 27, 2015

This is a pull request for #216 . Most of the work was already merged previously, here it's mostly cleanup stuff:

  • read security settings from the registry instead of portal properties, including removal of old properties, which are not used anymore
  • fix tests, add another robot test
  • changelog

There are also fixes in a number of other packages, which should be merged along with this PR, please wait with the merge until I add the list of other pull requests here.

When "use_email_as_login" setting is enabled, "E-mail" is displayed
instead of "Login Name" on the login form. This is now working
correctly due to the previous commit.
When "use_email_as_login" setting is enabled, "My email address is"
is displayed instead of "My user name is".
We are testing on the search view, since author info currently appears
only on search and listing views, not on document view etc.. See
also #337.
@jcerjak
Copy link
Member Author

jcerjak commented Jan 27, 2015

Added a list of pull requests, which should be merged along with this one. The tests are passing on my local machine, except I'm getting u'arguments[0] is undefined' errors with some of the robot tests,, e.g.:

Failure in test Scenario type title is normalized (test_types.robot)
Traceback (most recent call last):
  File "/home/ibi/.buildout/eggs/unittest2-0.5.1-py2.7.egg/unittest2/case.py", line 340, in run
    testMethod()
  File "/home/ibi/.buildout/eggs/robotsuite-1.6.1-py2.7.egg/robotsuite/__init__.py", line 455, in runTest
    assert last_status == 'PASS', last_message
AssertionError: WebDriverException: Message: u'arguments[0] is undefined' ; Stacktrace: 
    at anonymous (http://localhost:55001/plone/@@dexterity-types line 68 > Function:1:1)
    at handleEvaluateEvent (http://localhost:55001/plone/@@dexterity-types:68:20) 

These errors don't seem to be related to my changes, can you please take a look if it works for you, @tisto or @khink ? Here is the buildout for the security panel migration: plone/buildout.coredev#61

Otherwise it should be good to merge.

Thanks!

@jcerjak
Copy link
Member Author

jcerjak commented Feb 1, 2015

Which of the packages above should retain Plone 4 support? So we'd need to do something like: plone/plone.app.contenttypes@2347905

Timo Stollenwerk added 2 commits February 27, 2015 08:05
Conflicts:
	CHANGES.rst
	Products/CMFPlone/skins/plone_templates/default_error_message.pt
…o plip10359-security-controlpanel

Conflicts:
	CHANGES.rst
tisto added a commit that referenced this pull request Mar 2, 2015
@tisto tisto merged commit c62763e into master Mar 2, 2015
@gforcada gforcada deleted the plip10359-security-controlpanel branch March 2, 2015 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants