Plip10359 security controlpanel #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pprop = getToolByName(self.portal, 'portal_properties') | ||
| self.portal.manage_addProperty('validate_email', False, 'boolean') |
There was a problem hiding this comment.
@jcerjak Don't we have to check if that property already exist? I would expect this to fail if we would run it in Plone 4.x.
There was a problem hiding this comment.
you're right, I'll fix it
This restores Plone 4 compatibility
|
Plone 4 compatibility restored. |
| pprop = getToolByName(self.portal, 'portal_properties') | ||
| try: |
There was a problem hiding this comment.
try/except without a specific error are usually a bad idea because they will swallow any exception that might occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read security settings from the registry instead of portal properties. This is part of work on the security control panel migration: plone/Products.CMFPlone#216
This should be merged along with plone/Products.CMFPlone#362