support prefetching of users and groups #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passes prefetching call to plugins that support it
This was referenced Apr 14, 2016
|
Hence there was no activity for a long time, I propose to close this PR within next two weeks. If you do not feel ok with this, please speak up and provide us a rough schedule. |
|
@chaoflow Any pros and cons for this? Some timings maybe? I think this change would really help us but it would be good to know if there are any knock on affects and any alternatives? |
|
@jone do you have input on the performance and any feedback from using the code? |
|
There was no activity on this for a while. I close this request for now. If you plan to work further on this please reopen and go on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example for the sharing view in combination with LDAP it is very expensive to fetch user and group information with individual requests. To solve this we implemented for 4teamwork the possibility to prefetch users and groups for PAS plugins that support it.
relates: