Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Branch: refs/heads/master Date: 2016-03-02T21:18:54+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@0fbff88 Fixed html validation: bad value menu for attribute role on element section. This is in the footer actions portlet, which contains links to Sitemap, Accessibility, and Contact. Also, when the header is not shown, you get this warning: Section lacks heading. Also, when the header *is* shown, we get an error: The element 'header' must not appear as a descendant of the 'footer' element. Also, the section with class portletContent is always lacking a header. Solutions in this fix: - Removed the role from this section. - Changed all sections to divs. Files changed: M plone/app/portlets/portlets/actions.pt Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:54+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@c6ca0d5 Fixed html validation: Attribute alt not allowed on element input at this point. Fixed this in the login portlet. For the submit input, changed the alt to a title. The other inputs already have a label. Files changed: M plone/app/portlets/portlets/login.pt Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:55+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@c4ccd99 Removed role 'section' from section. A section is already a section, so there is no need for a role with this name/ Also, no such role exists. If no role is given explicitly, the default 'region' role is used, and such a default role should not be set, as browsers do that themselves. See http://w3c.github.io/html/sections.html#the-section-element Files changed: M plone/app/portlets/portlets/language.pt M plone/app/portlets/portlets/login.pt M plone/app/portlets/portlets/news.pt M plone/app/portlets/portlets/recent.pt M plone/app/portlets/portlets/review.pt M plone/app/portlets/portlets/rss.pt Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:55+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@fcb77d6 Changed section.portletContent into div. These have no heading, and a heading makes no sense here anyway, so they should be divs. Files changed: M plone/app/portlets/portlets/language.pt M plone/app/portlets/portlets/login.pt M plone/app/portlets/portlets/news.pt M plone/app/portlets/portlets/recent.pt M plone/app/portlets/portlets/review.pt M plone/app/portlets/portlets/rss.pt M plone/app/portlets/portlets/search.pt Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:55+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@360fcaa Changed main portlet sections into divs. These have no heading, so they should be divs. They have a *header*, but that is not a *heading*: those are h1-h6. Files changed: M plone/app/portlets/portlets/language.pt M plone/app/portlets/portlets/login.pt M plone/app/portlets/portlets/navigation.pt M plone/app/portlets/portlets/news.pt M plone/app/portlets/portlets/recent.pt M plone/app/portlets/portlets/review.pt M plone/app/portlets/portlets/rss.pt M plone/app/portlets/portlets/search.pt Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:55+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@74cf25b Added changelog entry for html validation fixes. Files changed: M CHANGES.rst Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-02T21:18:55+01:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/plone.app.portlets@88fe86e Added incompatibility note for changed html elements. Files changed: M CHANGES.rst Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-11T12:58:12+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.portlets@868b1bd pushed version according to http://semver.org/#spec-item-8 Files changed: M CHANGES.rst M README.rst M setup.py Repository: plone.app.portlets Branch: refs/heads/master Date: 2016-03-11T13:05:01+01:00 Author: Jens W. Klein (jensens) <jk@kleinundpartner.at> Commit: plone/plone.app.portlets@c7d6a52 Merge pull request #64 from plone/maurits-fix-html-validation Fix html validation Files changed: M CHANGES.rst M README.rst M plone/app/portlets/portlets/actions.pt M plone/app/portlets/portlets/language.pt M plone/app/portlets/portlets/login.pt M plone/app/portlets/portlets/navigation.pt M plone/app/portlets/portlets/news.pt M plone/app/portlets/portlets/recent.pt M plone/app/portlets/portlets/review.pt M plone/app/portlets/portlets/rss.pt M plone/app/portlets/portlets/search.pt M setup.py
- Loading branch information