Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange trac with GitHub, unify wording #197

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Exchange trac with GitHub, unify wording #197

merged 1 commit into from
Mar 17, 2016

Conversation

svx
Copy link
Member

@svx svx commented Mar 17, 2016

  • Remove trac, add Github
  • improve consistency of wording [no more mix of plip and PLIP in the same document]

gforcada added a commit that referenced this pull request Mar 17, 2016
@gforcada
Merge pull request #197 from plone/svx_5.1_doc_update_plipreview
e4d659f 
Exchange trac with GitHub, unify wording
@gforcada gforcada merged commit e4d659f into 5.1 Mar 17, 2016
@gforcada gforcada deleted the svx_5.1_doc_update_plipreview branch March 17, 2016 22:57
mister-roboto pushed a commit that referenced this pull request Apr 18, 2017
@geier
[fc] Repository: icalendar
0c7eafd 
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@d0fd108

Allow `=` in parameter values.

Some parameter values (e.g., BASE64 encoded binary data often ends with
one or two equal signs) may contain an equal sign (`=`). The current
implementation splits key-value pairs at all equal signs, which leads to
errors. Especially icalendar files generated by Apple's software often
feature BASE64 encoded binary data in parameter values.

This patch introduces a new parameter `maxsplit` to
icalendar.parser.q_split() which works similar as python's
string.split(sep, maxsplit) which we then use to split parameter
key-value pairs only at the first equal sign.

This patch fixes #197.

Files changed:
M CHANGES.rst
M src/icalendar/parser.py
M src/icalendar/tests/apple_xlocation_test.py
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@124b328

Moved test_apple_xlocation() to test_icalendar.py

Files changed:
M src/icalendar/tests/test_icalendar.py
D src/icalendar/tests/apple_xlocation_test.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@b82893f

New test for broken properties.

The fix for #197 makes the test data used for testing the error
messages for broken properties (which was valid data) work with
icalendar, we therefor need a new test with actually invalid data.

Files changed:
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Markus Unterwaditzer (untitaker) <markus@unterwaditzer.net>
Commit: collective/icalendar@0f408d8

Fix q_split for maxsplit=0

Files changed:
M src/icalendar/parser.py
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Markus Unterwaditzer (untitaker) <markus@unterwaditzer.net>
Commit: collective/icalendar@805f59d

Extend tests

Files changed:
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:19:43+02:00
Author: Christian Geier (geier) <github@lostpackets.de>
Commit: collective/icalendar@8a52e56

Merge pull request #207 from geier/fix_base64_equal

Allow `=` in parameter values.

Files changed:
M CHANGES.rst
M src/icalendar/parser.py
M src/icalendar/tests/test_icalendar.py
D src/icalendar/tests/apple_xlocation_test.py
mister-roboto pushed a commit that referenced this pull request Apr 18, 2017
@geier
[fc] Repository: icalendar
b86b0e8 
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@d0fd108

Allow `=` in parameter values.

Some parameter values (e.g., BASE64 encoded binary data often ends with
one or two equal signs) may contain an equal sign (`=`). The current
implementation splits key-value pairs at all equal signs, which leads to
errors. Especially icalendar files generated by Apple's software often
feature BASE64 encoded binary data in parameter values.

This patch introduces a new parameter `maxsplit` to
icalendar.parser.q_split() which works similar as python's
string.split(sep, maxsplit) which we then use to split parameter
key-value pairs only at the first equal sign.

This patch fixes #197.

Files changed:
M CHANGES.rst
M src/icalendar/parser.py
M src/icalendar/tests/apple_xlocation_test.py
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@124b328

Moved test_apple_xlocation() to test_icalendar.py

Files changed:
M src/icalendar/tests/test_icalendar.py
D src/icalendar/tests/apple_xlocation_test.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Christian Geier (geier) <geier@lostpackets.de>
Commit: collective/icalendar@b82893f

New test for broken properties.

The fix for #197 makes the test data used for testing the error
messages for broken properties (which was valid data) work with
icalendar, we therefor need a new test with actually invalid data.

Files changed:
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Markus Unterwaditzer (untitaker) <markus@unterwaditzer.net>
Commit: collective/icalendar@0f408d8

Fix q_split for maxsplit=0

Files changed:
M src/icalendar/parser.py
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:07:41+02:00
Author: Markus Unterwaditzer (untitaker) <markus@unterwaditzer.net>
Commit: collective/icalendar@805f59d

Extend tests

Files changed:
M src/icalendar/tests/test_icalendar.py
Repository: icalendar
Branch: refs/heads/master
Date: 2017-04-19T00:19:43+02:00
Author: Christian Geier (geier) <github@lostpackets.de>
Commit: collective/icalendar@8a52e56

Merge pull request #207 from geier/fix_base64_equal

Allow `=` in parameter values.

Files changed:
M CHANGES.rst
M src/icalendar/parser.py
M src/icalendar/tests/test_icalendar.py
D src/icalendar/tests/apple_xlocation_test.py
mister-roboto pushed a commit that referenced this pull request May 26, 2020
@pysailor
[fc] Repository: plone.app.content
9fa5a47 
Branch: refs/heads/master
Date: 2020-05-25T14:26:12+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.content@0409d15

Do not require mock on Python2.7

Fixes #198

Files changed:
A news/198.bugfix
M plone/app/content/tests/test_contents.py
M plone/app/content/tests/test_widgets.py
M setup.py
Repository: plone.app.content

Branch: refs/heads/master
Date: 2020-05-25T14:57:17+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.content@3f5b501

Do not break with unknown MIME types

Fixes #197

Files changed:
A news/197.bugfix
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_widgets.py
Repository: plone.app.content

Branch: refs/heads/master
Date: 2020-05-26T14:13:41+02:00
Author: Wolfgang Thomas (pysailor) <thomas@syslab.com>
Commit: plone/plone.app.content@3c2e37b

Merge pull request #199 from plone/ale-improvements

Do not break with unknown MIME types

Files changed:
A news/197.bugfix
A news/198.bugfix
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_contents.py
M plone/app/content/tests/test_widgets.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Jul 8, 2021
@jensens
[fc] Repository: plone.app.theming
8ac45a0 
Branch: refs/heads/4.1.x
Date: 2021-07-07T01:34:25+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@dcbc5dc

Avoid Server Side Request Forgery via lxml parser.

Taken over from [`PloneHotfix20210518`](https://plone.org/security/hotfix/20210518/server-side-request-forgery-via-lxml-parser).

Strangely, several tests in `test_transforms` fail, seemingly because we try to load a theme html from the tile system.
This may depend on the `absolutePrefix` setting.
Commenting out the new FailingFileSystemResolver, helps.  But that is one of the parts that brings extra security.

In practice with the hotfix, I have not seen it fail.  Also, I would expect a big cry out if this part was broken.
But these failures are definitely  suspect.

Files changed:
A news/3274.bugfix
A src/plone/app/theming/tests/package_theme.txt
M src/plone/app/theming/tests/test_utils.py
M src/plone/app/theming/utils.py
Repository: plone.app.theming

Branch: refs/heads/4.1.x
Date: 2021-07-07T16:25:16+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@f7b173b

Fixed test_transform.py after merging the hotfix.

Problem is that `test_transforms.setUp` sets `settings.rules` to `python://plone.app.theming/tests/rules.xml`.
The PythonResolver translates this to an absolute file system path like `/Users/maurits/.../src/plone/app/theming/tests/rules.xml`.
The rules file has `&lt;theme href="theme.html" /&gt;`.
This becomes an absolute file system path like `/Users/maurits/.../src/plone/app/theming/tests/theme.html`.
And then the FailingFileSystemResolver of the hotfix kicks in and throws an error:

  File system access not allowed: '/Users/maurits/.../src/plone/app/theming/tests/theme.html'

At this point in the diazo code, the absolute prefix is not used, so you cannot fix it with that.

The main fix in this commit is letting `rules.xml` reference the theme as `python://plone.app.theming/tests/theme.html`.
Then it works again.

This was a problem in the tests, but it may happen for real.
But I found this hard to reproduce.
I tried using `python://plonetheme.barceloneta/theme/rules.xml` in the theming controlpanel,
but even without the hotfix this meant the theme could not be displayed.
I have not heard anyone complain that theming fails with the hotfix, so maybe no one is using the `python://` path for the rules.

This commit removes test_internal_resolver, because this did not actually test the internal resolver.
It created an XMLParser with an InternalResolver, but this was not needed:
neither the rules nor the theme contained anything that needed to be resolved internally (traversed within the Plone Site).
The internal resolver is already tested in the test_includes method.

Files changed:
M src/plone/app/theming/tests/paramrules.xml
M src/plone/app/theming/tests/rules.xml
M src/plone/app/theming/tests/test_transform.py
Repository: plone.app.theming

Branch: refs/heads/4.1.x
Date: 2021-07-08T08:23:36+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.theming@bd84ded

Merge pull request #197 from plone/hotfix-20210518-41x

Hotfix 20210518 [4.1.x]

Files changed:
A news/3274.bugfix
A src/plone/app/theming/tests/package_theme.txt
M src/plone/app/theming/tests/paramrules.xml
M src/plone/app/theming/tests/rules.xml
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/tests/test_utils.py
M src/plone/app/theming/utils.py
mister-roboto pushed a commit that referenced this pull request May 2, 2022
@gforcada
[fc] Repository: plone.app.discussion
1d0239b 
Branch: refs/heads/master
Date: 2022-05-02T23:03:24+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.discussion@ef6b558

Make compatible with robotframework 3-5.

Files changed:
A news/5.bugfix
M plone/app/discussion/tests/robot/test_discussion.robot
M plone/app/discussion/tests/robot/test_moderation.robot
Repository: plone.app.discussion

Branch: refs/heads/master
Date: 2022-05-03T01:13:24+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.discussion@12e057c

Merge pull request #197 from plone/robotframework5

Make compatible with robotframework 3-5.

Files changed:
A news/5.bugfix
M plone/app/discussion/tests/robot/test_discussion.robot
M plone/app/discussion/tests/robot/test_moderation.robot
mister-roboto pushed a commit that referenced this pull request Jun 2, 2022
@thet
[fc] Repository: plone.staticresources
c6cdb12 
Branch: refs/heads/1.x
Date: 2022-03-23T16:02:35+01:00
Author: Paul Grunewald (pgrunewald) <paul.grunewald@tu-dresden.de>
Commit: plone/plone.staticresources@bc348ff

Omit system paths in compiled js files

Files changed:
A news/195.bugfix
M src/plone/staticresources/_scripts/_generate_gruntfile.py
Repository: plone.staticresources

Branch: refs/heads/1.x
Date: 2022-06-02T18:05:21+02:00
Author: Johannes Raggam (thet) <thetetet@gmail.com>
Commit: plone/plone.staticresources@0dc8f0b

Merge pull request #197 from plone/pgrunewald-cwd-fix-1.x

Omit system paths in compiled js files

Files changed:
A news/195.bugfix
M src/plone/staticresources/_scripts/_generate_gruntfile.py
mister-roboto pushed a commit that referenced this pull request Sep 20, 2024
@petschki
[fc] Repository: plone.app.z3cform
05a847c 
Branch: refs/heads/master
Date: 2024-09-16T14:34:45+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.z3cform@a783df5

Implement `pat-contentbrowser` widget

Files changed:
A plone/app/z3cform/templates/contentbrowser_display.pt
A plone/app/z3cform/widgets/contentbrowser.py
M plone/app/z3cform/converters.py
M plone/app/z3cform/converters.zcml
M plone/app/z3cform/interfaces.py
M plone/app/z3cform/templates/relateditems_display.pt
M plone/app/z3cform/widgets.zcml
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2024-09-16T14:34:45+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.z3cform@576d427

changenote

Files changed:
A news/197.feature
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2024-09-16T14:34:45+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.z3cform@3e03ac9

update tests

Files changed:
M plone/app/z3cform/tests/test_widgets.py
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2024-09-16T14:34:45+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.z3cform@54ce09d

switch `LinkWidget` to contentbrowser

Files changed:
M plone/app/z3cform/templates/link_input.pt
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2024-09-16T14:59:42+02:00
Author: Peter Mathis (petschki) <peter.mathis@kombinat.at>
Commit: plone/plone.app.z3cform@bc626b5

Add BBB adapters

Files changed:
M plone/app/z3cform/converters.py
M plone/app/z3cform/converters.zcml
Repository: plone.app.z3cform

Branch: refs/heads/master
Date: 2024-09-20T08:08:41+02:00
Author: Peter Mathis (petschki) <petschki@users.noreply.github.com>
Commit: plone/plone.app.z3cform@d38e1fa

Merge pull request #197 from plone/pat-contentbrowser-widget

Implement `ContentBrowserWidget` for the new `pat-contentbrowser` pattern

Files changed:
A news/197.feature
A plone/app/z3cform/templates/contentbrowser_display.pt
A plone/app/z3cform/widgets/contentbrowser.py
M plone/app/z3cform/converters.py
M plone/app/z3cform/converters.zcml
M plone/app/z3cform/interfaces.py
M plone/app/z3cform/templates/link_input.pt
M plone/app/z3cform/templates/relateditems_display.pt
M plone/app/z3cform/tests/test_widgets.py
M plone/app/z3cform/widgets.zcml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
04 type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svx @gforcada