Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to 5.1 branch #198

Merged
merged 1 commit into from
Mar 17, 2016
Merged

Update README to 5.1 branch #198

merged 1 commit into from
Mar 17, 2016

Conversation

svx
Copy link
Member

@svx svx commented Mar 17, 2016

  • Update links for jenkins and badges to 5.1

gforcada added a commit that referenced this pull request Mar 17, 2016
@gforcada gforcada merged commit 2cb4681 into 5.1 Mar 17, 2016
@gforcada gforcada deleted the svx_5.1_update_README branch March 17, 2016 22:58
@gforcada
Copy link
Member

Thanks!

mister-roboto pushed a commit that referenced this pull request Feb 19, 2019
Branch: refs/heads/master
Date: 2019-02-12T20:45:42+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.upgrade@94e8413

Fixed permission error while removing old resource registries.

Fixes plone/plone.app.upgrade#197

Files changed:
A news/197.bugfix
M plone/app/upgrade/v52/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-19T11:57:28+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@2659b44

Merge pull request #198 from plone/maurits-fix-remove_legacy_resource_registries

Fixed permission error while removing old resource registries.

Files changed:
A news/197.bugfix
M plone/app/upgrade/v52/betas.py
mister-roboto pushed a commit that referenced this pull request Feb 19, 2019
Branch: refs/heads/master
Date: 2019-02-12T20:45:42+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.upgrade@94e8413

Fixed permission error while removing old resource registries.

Fixes plone/plone.app.upgrade#197

Files changed:
A news/197.bugfix
M plone/app/upgrade/v52/betas.py
Repository: plone.app.upgrade

Branch: refs/heads/master
Date: 2019-02-19T11:57:28+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.upgrade@2659b44

Merge pull request #198 from plone/maurits-fix-remove_legacy_resource_registries

Fixed permission error while removing old resource registries.

Files changed:
A news/197.bugfix
M plone/app/upgrade/v52/betas.py
mister-roboto pushed a commit that referenced this pull request Jun 21, 2019
Branch: refs/heads/master
Date: 2019-06-21T17:20:08+02:00
Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.widgets@987a218

Adapt the tests to the new robotframework syntax (#198)

Fixes #199

Files changed:
A news/199.bugfix
M plone/app/widgets/tests/robot/test_datetime_widget.robot
mister-roboto pushed a commit that referenced this pull request May 26, 2020
Branch: refs/heads/master
Date: 2020-05-25T14:26:12+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.content@0409d15

Do not require mock on Python2.7

Fixes #198

Files changed:
A news/198.bugfix
M plone/app/content/tests/test_contents.py
M plone/app/content/tests/test_widgets.py
M setup.py
Repository: plone.app.content

Branch: refs/heads/master
Date: 2020-05-25T14:57:17+02:00
Author: ale-rt (ale-rt) <alessandro.pisa@gmail.com>
Commit: plone/plone.app.content@3f5b501

Do not break with unknown MIME types

Fixes #197

Files changed:
A news/197.bugfix
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_widgets.py
Repository: plone.app.content

Branch: refs/heads/master
Date: 2020-05-26T14:13:41+02:00
Author: Wolfgang Thomas (pysailor) <thomas@syslab.com>
Commit: plone/plone.app.content@3c2e37b

Merge pull request #199 from plone/ale-improvements

Do not break with unknown MIME types

Files changed:
A news/197.bugfix
A news/198.bugfix
M plone/app/content/browser/vocabulary.py
M plone/app/content/tests/test_contents.py
M plone/app/content/tests/test_widgets.py
M setup.py
mister-roboto pushed a commit that referenced this pull request Jul 8, 2021
Branch: refs/heads/master
Date: 2021-07-07T21:10:20+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@6624361

Avoid Server Side Request Forgery via lxml parser.

Taken over from [`PloneHotfix20210518`](https://plone.org/security/hotfix/20210518/server-side-request-forgery-via-lxml-parser).

Strangely, several tests in `test_transforms` fail, seemingly because we try to load a theme html from the tile system.
This may depend on the `absolutePrefix` setting.
Commenting out the new FailingFileSystemResolver, helps.  But that is one of the parts that brings extra security.

In practice with the hotfix, I have not seen it fail.  Also, I would expect a big cry out if this part was broken.
But these failures are definitely  suspect.

Files changed:
A news/3274.bugfix
A src/plone/app/theming/tests/package_theme.txt
M src/plone/app/theming/tests/test_utils.py
M src/plone/app/theming/utils.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2021-07-07T21:10:25+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.theming@e0909f0

Fixed test_transform.py after merging the hotfix.

Problem is that `test_transforms.setUp` sets `settings.rules` to `python://plone.app.theming/tests/rules.xml`.
The PythonResolver translates this to an absolute file system path like `/Users/maurits/.../src/plone/app/theming/tests/rules.xml`.
The rules file has `&lt;theme href="theme.html" /&gt;`.
This becomes an absolute file system path like `/Users/maurits/.../src/plone/app/theming/tests/theme.html`.
And then the FailingFileSystemResolver of the hotfix kicks in and throws an error:

  File system access not allowed: '/Users/maurits/.../src/plone/app/theming/tests/theme.html'

At this point in the diazo code, the absolute prefix is not used, so you cannot fix it with that.

The main fix in this commit is letting `rules.xml` reference the theme as `python://plone.app.theming/tests/theme.html`.
Then it works again.

This was a problem in the tests, but it may happen for real.
But I found this hard to reproduce.
I tried using `python://plonetheme.barceloneta/theme/rules.xml` in the theming controlpanel,
but even without the hotfix this meant the theme could not be displayed.
I have not heard anyone complain that theming fails with the hotfix, so maybe no one is using the `python://` path for the rules.

This commit removes test_internal_resolver, because this did not actually test the internal resolver.
It created an XMLParser with an InternalResolver, but this was not needed:
neither the rules nor the theme contained anything that needed to be resolved internally (traversed within the Plone Site).
The internal resolver is already tested in the test_includes method.

Files changed:
M src/plone/app/theming/tests/paramrules.xml
M src/plone/app/theming/tests/rules.xml
M src/plone/app/theming/tests/test_transform.py
Repository: plone.app.theming

Branch: refs/heads/master
Date: 2021-07-08T08:23:16+02:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.theming@86d778e

Merge pull request #198 from plone/hotfix-20210518-master

Hotfix 20210518 [master]

Files changed:
A news/3274.bugfix
A src/plone/app/theming/tests/package_theme.txt
M src/plone/app/theming/tests/paramrules.xml
M src/plone/app/theming/tests/rules.xml
M src/plone/app/theming/tests/test_transform.py
M src/plone/app/theming/tests/test_utils.py
M src/plone/app/theming/utils.py
mister-roboto pushed a commit that referenced this pull request May 6, 2022
Branch: refs/heads/master
Date: 2022-05-05T22:08:05+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.discussion@73f1255

Removed z3c.autoinclude.plugin entrypoint.

Files changed:
A news/3188.bugfix
M setup.py
Repository: plone.app.discussion

Branch: refs/heads/master
Date: 2022-05-07T01:41:46+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.app.discussion@37dc258

Merge pull request #198 from plone/remove-autoinclude-entrypoint

Removed z3c.autoinclude.plugin entrypoint.

Files changed:
A news/3188.bugfix
M setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants