Add custom 404 not found page #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for 6-dev-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
39 tasks
stevepiercy
requested changes
Dec 22, 2022
requirements.txt
Outdated
| @@ -14,3 +14,4 @@ sphinx-togglebutton | |||
| sphinxcontrib.httpdomain # plone.restapi | |||
| sphinxcontrib.httpexample # plone.restapi | |||
| sphinxext-opengraph | |||
| sphinx-notfound-page | |||
There was a problem hiding this comment.
This should be moved between the following to preserve the sort order:
sphinx-design
sphinx-sitemap
|
Is any server configuration needed? |
error page for 404 is available at /404.html
ksuess
force-pushed
the
page-not-found
branch
from
78caed1
to
6fb6408
Compare
stevepiercy
approved these changes
Dec 22, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error page for 404 is available at /404.html
Minimum solution for issue #1399
This PR adds a new extension. Please run "make distclean" and rebuild to see the new generated /404.html