-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plone 6 Docs Final Release Checklist #1140
Comments
I really think a version number in the url or path makes sense. |
I think that RTD was on to something with the concept of https://6.docs.plone.org/foo When 7 comes out, then |
Given the inflexibility of the 5 and pre-5 versioning system, and the fact that two different physical servers are involved, it would be much easier to have DNS-based diffence. So 5.docs.plone.org instead of docs.plone.org/5. In that case docs.plone.org, latest.docs.plone.org and 6.docs.plone.org will soon all point to the version6 documentation, whereas 5.docs.plone.org, 4.docs.plone.org and 3.docs.plone.org point to the old ones. That way, the version-switcher on the old docs is easily adaptable, and even 3.docs.plone.org will have a direct dropdown to 6 If that's OK, I can start creating the necessary stuff for the [5-3] versions. It will incur of course a one-time searchengines confusion, but we'd have that anyway. Opinions, strong objections? |
@polyester thanks for the feedback. I support this plan, with a few changes in both your suggestions and my original checklist.
Please provide opinions and feedback. Thank you! |
In general, agreement. On the 404 page, given the quite extensive changes to URLs, I would probably be in favor of not offering https://x.docs.plone.org/whateveryouwerelookingfor, which is likely to not exist, but just an overview of https://x.docs.plone.org versions. As the de-facto "Keeper of the Ancient Scrolls", we already have an insane amount of NGINX redirects, and maintaining that in the future is a recipe for failure. Pointing the user to the entry point is probably wiser. |
Are these just static content servers that have nothing dynamic? If so, that makes sense. But if nginx can grab the filepath, pass it to a template, which in turn can render the filepath, it would be useful to the user and not require any additional redirect maintenance. Did I explain that well? IOW, a typical flow:
|
Plone [5-3] are just static HTML sites, but it has been a challenge to map things. There's simply no way you can map https://6.docs.plone.org/some-fancy-newtech to https://3.docs.plone.org/when-dinosaurs-still-roamed-the-earth I can probably whip up some "if not found, redirect to the canonical https://3.docs.plone.org" NGINX magic, but it might be challenging. I'll try. |
Ack, I goofed by omitting the target to redirect to |
BTW, thank you to whoever set up the new hostname for docs, but please keep me informed of any server configuration changes, so we can keep this checklist up to date: plone/documentation#1140 (comment).
as preparation, the following are now live: |
I have updated the checklist at the top to reflect the completed tasks and our desire to use |
@stevepiercy For 6.docs.plone.org: that currently (and actually since february already, just nobody noticed...) that is set up as an NGINX "alias" to 6.dev-docs.plone.org - so links to 6.docs.plone.org already work. Would be nicer to make it official, so that the name and filepath (currently /var/www/6.dev-docs.plone.org) reflect the official status, but there is no time pressure, just a need to coordinate because an ansible role needs to run to do the NGINX changes, and a github actions change plus deploy to deploy. Not sure if it's wiser to keep 6.dev-docs.plone.org as an alias for 6.docs.plone.org for a while, or just do a redirect. |
I have no access to make any of those changes.
Redirects will cause builds to fail wherever |
I do, after some soul- and passwordmanager-searching.
Note that the alias already works, so maybe we can already start running linkcheck against 6.docs.plone.org. |
Per a conversation with @sneridagh, we realized that we should be pulling the Volto submodule from the |
I would like to see redirect of 6.dev-docs.plone.org to 6.docs.plone.org prioritized. This because 6.docs.plone.org is still poorly indexed. And I think the reason is that 6.dev-docs.plone.org is still there and not permanently moved. |
I moved it up the list, but not into the "do now" list. I think it should be announced to the Community forum ahead of time to give people opportunity to fix their links now. Does that sound OK? |
it does. |
+1 from me for 6.doc.plone.org for the official address of Plone 6 documentation (instead of docs.plone.org without sub sub domain) as this means bookmarks of new documentation stay valid in the future with 7.docs.plone.org, …. |
Page not found page: New /404.html needs to be used as error page in web server configuration. |
and forget latest.docs.plone.org for the same reason: bookmarks and links to latest.docs.plone.org will be broken with Plone 7. |
Also, now that I think of it, people can use |
Added to checklist, and checked as answered the question regarding this. |
It's time to try to clean up the Documentation once again. @fredvd said I will be granted access to the machines that host Training and Documentation so that I can manage these things. However we need to make sure I know any history that should be preserved. @pbauer @ksuess @polyester @spereverde @fredvd @ericof @MrTango please review the above plan, and let me know if there is anything that should be changed or considered: Thank you! |
To be more precise: I'll drive the project management for this one from the AI-team perspective, help you keep things moving forward and give you access to services/folders/hosts/accounts if that is required and you want to take the responsibility for those. ;-) Let's get this going. |
The plan sounds reasonable for me. The broken search in 5.docs.plone.org is a blocker. During the short period of the switch docs.plone.org -> Plone 6 documentation it showed up that the search results are pointing to docs.plone.org/xy, which is wrong. |
I have tried in the past (and iirc succeeded) in seting up the stil live docs.plone.org build. I can repeat that, check with @polyester if that still works and if I'm not missing anything, so that we can deploy small fixes or changes to the current docs when we move them off the main docs.plone.org domain. But we shouldn't put more effort into that setup as necessary, but enough to keep it online for the next years. for reference. |
@fredvd the setup still works, I'll update the description for Ubuntu 22.04 for list of required packages, the default Python version changed. But the blocker is the access to the Algolia search account - we don't have access, and Algolia's terms and conditions make it very vague if we can get a new account. They make it very hard to find their free offering for opensource docs projects anyway, much harder than it used to be. If that becomes too annoying, we can remove the Algolia search and just provide Sphinx's less-than-pretty search for the 5 docs. And who knows, maybe create a knowledge bucket at Nuclia; at least we know them and they're a friendly bunch ;-) |
Sound like a plan. And it sounds like plan B, but maybe we should make this plan A with our limited resource available and forget about Algolia. Freebies come and go when VC demands their return on investment. Then we could even allow people to search in both docs at the same time, or at least show the same search interface and quality of results. |
Personally I never liked the Algolia interface. I want a page of results that I can right-click and open in a new tab. Algolia's search results is limited to only a few items and clicking on a result keeps the focus in the same window. I would love to see it go away. Nuclia would be my preferred choice, then Sphinx's default. Nuclia will be a GSoC project. I assume that Sphinx's default search would be not a lot of effort. If that is true, then I would opt to drop Algolia and use Sphinx for now, then adopt Nuclia to search Plone 5 and 6 docs for the GSoC project. |
@fredvd @stevepiercy Algolia search is gone, https://5.docs.plone.org (which works as URL) and the currently-equivalent https://docs.plone.org now use the standard Sphinx search. |
Note to future self: the only reason the 5 docs need a buildout of full Plone, which gets increasingly challenging as Python versions move on, is the plone.api docs and their use of autodoc. An escape hatch could be to point that sub-part of the 5 docs to the 6 docs. |
In Plone 6 Documentation, I don't think we do a full buildout for any of the submodules that use autodoc, including plone.api and plone.restapi. Perhaps there is something from v6 that could be adapted to v5? There is some usefulness to git submodules.
I don't know if you can add a banner announcement for just a section of the v5 docs, but that would be the most appropriate. Else something on the index of plone.api would have to do. |
After reviewing the checklist at the top of this issue, and checking off a few items, I think that the idea of setting up and tearing down a branch of I would like to get this entire checklist done either before or during Beethoven Sprint, May 15-19, 2023. |
This item is not possible, unless someone smarter than I knows how to make it work. I have crossed it off.
As I understand it, a submodule points to only a single branch of a remote repository. In Volto we develop on When we cut the next major release of Plone and its documentation, then we can create a snapshot of older versions of Plone and Volto docs. This could be an issue for folks looking for older minor versions of Volto docs. |
The branch name in documentation should be I have created a new branch |
To make the task list easier to parse, I plopped all the remaining open tasks at the end of the task list, reordered them in a somewhat logical sequence, and assigned them by |
"Merge |
Post to community coming soon. Closing as complete. w00t! |
Plone 6 Docs Plan
This is a checklist of tasks to perform just before the launch of the final release of Plone 6 Docs. Please add items as needed.
We will add
latest.docs.plone.org
as an alias for6.docs.plone.org
. This could possibly future proof docs to always point at the latest URL as the version of Plone increases. It could also detect when a page moves withlinkcheck
andintersphinx
.Plone 6 Docs Questions
docs.plone.org
? See comments starting with Plone 6 Docs Final Release Checklist #1140 (comment)Plone 5 and earlier Docs
5.docs.plone.org
4.docs.plone.org
3.docs.plone.org
3
and4
version switchers to include6
, if possible.Plone 6 Docs to do now items
api.plone.org
to6.docs.plone.org/plone.api
. See Redirect api.plone.org to Plone 6 Documentation #13836.docs.plone.org
.latest.docs.plone.org
to point to6.docs.plone.org
.conf.py
. Links and sitemap and more after v6 release #1385conf.py
. Fix ogp_image URL plone.restapi#1556conf.py
. Fix URLs to Plone 6 docs volto#4143robots.txt
.6.0
branch as well as6-dev
. We will continue to use6-dev
for development and testing.Prepare each submodule for testing
conf.py
, update the Intersphinxplone
target to6.docs.plone.org
.plone/plone.api
, update the URLs containing6.dev-docs.plone.org
to6.docs.plone.org
.plone/plone.restapi
, update the URLs containing6.dev-docs.plone.org
to6.docs.plone.org
.plone/volto
, update the URLs containing6.dev-docs.plone.org
to6.docs.plone.org
. Use new URL 6.docs.plone.org volto#4726Canceled
Change Volto's submodule branch to be pulled intoEDIT: Not feasible. See Plone 6 Docs Final Release Checklist #1140 (comment)plone/documentation
frommaster
to16.x.x
(latest and stable).In each submodule, create a new branch,See Plone 6 Docs Final Release Checklist #1140 (comment)6-deploy
, to be merged into the latest and stable branch of each repo.UpdateSee Plone 6 Docs Final Release Checklist #1140 (comment)plone/documentation
Makefile to pull in these submodules' new branches for testing.Merge each submodules'See Plone 6 Docs Final Release Checklist #1140 (comment)6-deploy
branch into its stable and latest branch, eithermaster
or16.x.x
for Volto.UpdateSee Plone 6 Docs Final Release Checklist #1140 (comment)plone/documentation
Makefile to pull in these submodules'master
or16.x.x
branch for deployment.Must be done before launch
6.dev-docs.plone.org
to6.docs.plone.org
. Runlinkcheckbroken
from Training, Documentation and its submodules. Purge that old version from the server. Google has indexed that site, leading to very confusing and outdated search results. @polyester6.dev-docs.plone.org
. @polyester6.0
branch to6.docs.plone.org
(update server paths?). @polyesterconf.py
underlinkcheck_ignore
, clean up any remaining commented links. @stevepiercyMerge6-dev
into6.0
. @stevepiercy6.docs.plone.org
. @stevepiercy6.0
as default branch. @stevepiercydocs.plone.org
to6.docs.plone.org
. @polyesterdocs.plone.org
under "Plone 6 Docs" instead of "Plone 3-4-5 Docs". See https://stats.plone.org/index.php?date=yesterday&module=SitesManager&format=html&action=index&idSite=2&period=day&segment=&widget=&showtitle=1&random=1154#?period=day&date=yesterday @stevepiercylinkcheckbroken
on Training and REST API. @stevepiercy/404.html
as the error page. @polyesterThe text was updated successfully, but these errors were encountered: