Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ogp_image URL #1556

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Fix ogp_image URL #1556

merged 4 commits into from
Dec 16, 2022

Conversation

stevepiercy
Copy link
Contributor

No description provided.

@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Dec 16, 2022

Deploy Preview for plone-restapi ready!

Name Link
🔨 Latest commit be7048a
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/639cdc11d38856000b8d902e
😎 Deploy Preview https://deploy-preview-1556--plone-restapi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy
Copy link
Contributor Author

Jenkins failed on the first run, so I retried it and it is running now. I don't think this PR should affect the failing test, as it seemed to be a timeout issue. Should I go ahead and merge this?

@davisagli davisagli merged commit 3814bad into master Dec 16, 2022
@davisagli davisagli deleted the ogp-image-plone-logo-fix branch December 16, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants