-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
take RichTextBehavior fields into account when using google translate #465
Conversation
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
I don't know if you can help me here @1letter and @petschki I need some review on this to have the confirmation that this is right. The point is that we have some JS code to get the value of a field and send it through a browser view to a translation service (this is already implemented in p.a.multilingual yay!), but it does not work with the current richtext fields although I do these changes. |
I'll take a look today. I saw some issues notably that my translation page is getting longer and longer every second 😉 ... I'll come up with some improvements. |
Use the latest code in And if you have time, check also #468 :) |
07143a5
to
1bdb7ab
Compare
I've rewritten the babel helper in order to meet the current classic-ui standards. (still some unfortunately setting the content of tinymce to the translated text is a bit flaky ... need to check whats the problem there. Sometimes I see updated word count but no content 🤔 NOTE: this also works with every |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
Fixes #464
The old code had references to archetypes fields, not needed any more, and ignored current RichText fields.
This implementation works only with fields coming from the RichTextBehavior. It can't work with standard schema based RichText fields, because they have no marker in the HTML to signal that they are rich text fields.