Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take RichTextBehavior fields into account when using google translate (branch 7.x) #466

Closed

Conversation

erral
Copy link
Member

@erral erral commented Sep 29, 2024

Fixes #464 for branch 7.x.

See #465 for comments.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral force-pushed the erral-modernize-gtranslate-branch-7.x branch from 616c4f1 to 5524457 Compare September 29, 2024 14:10
@erral
Copy link
Member Author

erral commented Sep 29, 2024

@jenkins-plone-org please run jobs

@erral erral changed the title take RichTextBehavior fields into account when using google translate take RichTextBehavior fields into account when using google translate (branch 7.x) Sep 30, 2024
@erral erral changed the base branch from 7.x to erral-issue-303-branch-7.x October 7, 2024 08:33
@erral erral closed this Oct 7, 2024
@erral erral force-pushed the erral-modernize-gtranslate-branch-7.x branch from 5524457 to 81a9684 Compare October 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants