Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockMailHostLayer is outdated #61

Closed
ale-rt opened this issue Dec 12, 2019 · 1 comment · Fixed by #64
Closed

MockMailHostLayer is outdated #61

ale-rt opened this issue Dec 12, 2019 · 1 comment · Fixed by #64
Labels
01 type: bug

Comments

@ale-rt
Copy link
Member

ale-rt commented Dec 12, 2019

In this lines

plone.app.testing/src/plone/app/testing/layers.py

Lines 388 to 392 in 61933b7

portal.email_from_address = 'noreply@example.com'
portal.email_from_name = 'Plone Site'
portal._original_MailHost = portal.MailHost
portal.MailHost = mailhost = MockMailHost('MailHost')
portal.MailHost.smtp_host = 'localhost'

a site setup that is no longer operational since quite a lot of time is used.
Nowadays we should use the registry.
@ale-rt
Copy link
Member Author

ale-rt commented Dec 12, 2019

Note: see a possible fix in

plone.app.testing/src/plone/app/testing/layers.py

Lines 388 to 393 in d2ea19b

registry = getUtility(IRegistry, context=portal)
registry["plone.email_from_address"] = "noreply@example.com"
registry["plone.email_from_name"] = u"Plone site"
portal._original_MailHost = portal.MailHost
portal.MailHost = mailhost = MockMailHost('MailHost')
portal.MailHost.smtp_host = 'localhost'
, although the smtp_host is still configured in the old way.

ale-rt added a commit that referenced this issue Feb 4, 2020
@ale-rt
Fix some test isolation issues
53ac601 
Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE
to be used in multiple testcases (Fixes #61),

Properly configure the mail sender setting the appropriate registry
records (Fixes #62),

Adds test coverage.
@ale-rt ale-rt mentioned this issue Feb 4, 2020
Merged
ale-rt added a commit that referenced this issue Feb 5, 2020
@ale-rt
Fix some test isolation issues
84beb26 
Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE
to be used in multiple testcases (Fixes #61),

Properly configure the mail sender setting the appropriate registry
records (Fixes #62),

Adds test coverage.
ale-rt added a commit that referenced this issue Feb 5, 2020
@ale-rt
Fix some test isolation issues
e8ba5ff 
Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE
to be used in multiple testcases (Fixes #61),

Properly configure the mail sender setting the appropriate registry
records (Fixes #62),

Adds test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some test isolation issues plone/plone.app.testing
1 participant
@ale-rt