Fix some test isolation issues #64
Conversation
|
@ale-rt thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
It seems to me the failing robot test is unrelated |
|
Failing build https://jenkins.plone.org/job/pull-request-5.2-3.7/842/ |
| if not registry["plone.email_from_address"]: | ||
| registry["plone.email_from_address"] = "noreply@example.com" | ||
| if not registry["plone.email_from_name"]: | ||
| registry["plone.email_from_name"] = u"Plone site" |
There was a problem hiding this comment.
I have a small reservation: this changes the registry, but does not undo this after test teardown.
But that was already the case for the properties on the portal, so I guess it is no big deal.
There was a problem hiding this comment.
I actually want to do that!
Thanks anyway!
Fix a test isolation issue that was preventing the MOCK_MAILHOST_FIXTURE
to be used in multiple testcases (Fixes #61),
Properly configure the mail sender setting the appropriate registry
records (Fixes #62),
Adds test coverage.