Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockMailHostLayer: clean up the registry on test tear down #67

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Feb 9, 2020

Follow up #64

@mister-roboto
Copy link

@ale-rt thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ale-rt ale-rt force-pushed the mock-mailhost branch 2 times, most recently from 7475fc7 to baf221d Compare February 9, 2020 11:53
@coveralls
Copy link

coveralls commented Feb 9, 2020

Coverage Status

Coverage increased (+0.4%) to 58.482% when pulling 5b7b6e6 on mock-mailhost into d0a6bdd on master.

@ale-rt
Copy link
Member Author

ale-rt commented Feb 9, 2020

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member Author

ale-rt commented Feb 11, 2020

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees
Copy link
Member

One passing Jenkins job. The failures on the other two seem unrelated. I merge.

@mauritsvanrees mauritsvanrees merged commit 80cddda into master Feb 11, 2020
@mauritsvanrees mauritsvanrees deleted the mock-mailhost branch February 11, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants