Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed object and objectsubform. #52

Merged
merged 2 commits into from
Mar 20, 2017
Merged

Removed object and objectsubform. #52

merged 2 commits into from
Mar 20, 2017

Conversation

mauritsvanrees
Copy link
Member

z3c.form 3.3 removed the underlying code.
See zopefoundation/z3c.form#38 for upstream changes.

I don't know if object and objectsubform are used much, or at all. Removing it is backwards incompatible, which is exactly what the upstream z3c.form change is. I guess the only way around that, if we want to, is to copy over z3c.form code from 3.2.x, if that still works.

It seems we only supplied our own versions of ObjectSubForm in order to add a get_closest_content method. But I don't see this method get used anywhere, not even in Plone 4.3.

I will test this in combination with a buildout.coredev pull request that updates to latest z3c.form 3.4.0. Let's see what Jenkins has to say about that.

@davisagli
Copy link
Member

This might be used by collective.z3cform.datagridfield -- the code that was removed from z3c.form definitely is.

mauritsvanrees and others added 2 commits March 20, 2017 11:53
@jensens jensens force-pushed the remove-object-subform branch from 2b24ba0 to 1cc5945 Compare March 20, 2017 10:54
@jensens
Copy link
Member

jensens commented Mar 20, 2017

I am at Datagridfield. I case of trouble I just copy over the missing code. This one is ready for merge then.

@jensens jensens merged commit b814781 into master Mar 20, 2017
@jensens jensens deleted the remove-object-subform branch March 20, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants