Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z3c.form 3.3 removed the underlying code.
See zopefoundation/z3c.form#38 for upstream changes.
I don't know if object and objectsubform are used much, or at all. Removing it is backwards incompatible, which is exactly what the upstream z3c.form change is. I guess the only way around that, if we want to, is to copy over z3c.form code from 3.2.x, if that still works.
It seems we only supplied our own versions of ObjectSubForm in order to add a
get_closest_content
method. But I don't see this method get used anywhere, not even in Plone 4.3.I will test this in combination with a buildout.coredev pull request that updates to latest z3c.form 3.4.0. Let's see what Jenkins has to say about that.