Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAJOR overhaul of ObjectWidget and a bunch of fixes #38

Merged
merged 33 commits into from
Mar 9, 2016

Conversation

agroszer
Copy link
Contributor

No description provided.

@agroszer agroszer changed the title MAJOR overhaul of ObjectWidget MAJOR overhaul of ObjectWidget and a bunch of fixes Feb 23, 2016
@mauritsvanrees
Copy link
Member

Wow, big one. Thanks!
I can't look at this in detail.
But I wonder if there is code in Plone that will be broken by this. So let's let Jenkins test it. I have started two jobs:

Plone 4.3 (if this one fails, we may simply want to switch to using a stable 3.2.x branch of z3c.form):
http://jenkins.plone.org/job/pull-request-4.3/232/

Plone 5:
http://jenkins.plone.org/job/pull-request-5.0/962/

Well, I wanted to let Jenkins test it, but the jobs failed to start... :-( Maybe because the way they are setup does not work for repositories in the zopefoundation, though that should not matter. Maybe temporary failure.

# Conflicts:
#	setup.py
#	src/z3c/form/browser/radio.py
agroszer added a commit that referenced this pull request Mar 9, 2016
MAJOR overhaul of ObjectWidget and a bunch of fixes
@agroszer agroszer merged commit 436475a into master Mar 9, 2016
@agroszer agroszer deleted the adamg-objectwidget branch March 9, 2016 13:46
mauritsvanrees added a commit to plone/plone.app.z3cform that referenced this pull request Nov 16, 2016
z3c.form 3.3 removed the underlying code.

See zopefoundation/z3c.form#38 for upstream changes.
jensens pushed a commit to plone/plone.app.z3cform that referenced this pull request Feb 6, 2017
z3c.form 3.3 removed the underlying code.

See zopefoundation/z3c.form#38 for upstream changes.
jensens pushed a commit to plone/plone.app.z3cform that referenced this pull request Mar 20, 2017
z3c.form 3.3 removed the underlying code.

See zopefoundation/z3c.form#38 for upstream changes.
mister-roboto pushed a commit to plone/buildout.coredev that referenced this pull request Mar 20, 2017
Branch: refs/heads/master
Date: 2017-03-20T11:53:57+01:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.app.z3cform@e9ed9b8

Removed `object` and `objectsubform`.

z3c.form 3.3 removed the underlying code.

See zopefoundation/z3c.form#38 for upstream changes.

Files changed:
M CHANGES.rst
M plone/app/z3cform/configure.zcml
D plone/app/z3cform/object.py
D plone/app/z3cform/objectsubform.py
D plone/app/z3cform/tests/test_objectsubform.py
Repository: plone.app.z3cform
Branch: refs/heads/master
Date: 2017-03-20T11:54:30+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@1cc5945

reflect breaking change in version number

Files changed:
M CHANGES.rst
M setup.py
Repository: plone.app.z3cform
Branch: refs/heads/master
Date: 2017-03-20T15:40:34+01:00
Author: Jens W. Klein (jensens) <jk@kleinundpartner.at>
Commit: plone/plone.app.z3cform@b814781

Merge pull request #52 from plone/remove-object-subform

Removed `object` and `objectsubform`.

Files changed:
M CHANGES.rst
M plone/app/z3cform/configure.zcml
M setup.py
D plone/app/z3cform/object.py
D plone/app/z3cform/objectsubform.py
D plone/app/z3cform/tests/test_objectsubform.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants