Dx container site root #85
Conversation
|
@jaroel please dont use WIP in the title, but the labels provided. Using the labels I and others involved in PR management are able to filter the PRs and issues. Thanks! |
ps resolveDottedName either returns or raises
jaroel
force-pushed
the
dxcontainer-siteroot
branch
from
49f3890 to
9e036ea
Compare
…hema, which triggers portalTypeToSchemaName, etc.
'mmm why would Plone Site have no fields?'
An utilities attibute could be anything for non-site root objects This reverts commit 8ca5a1d.
There was a problem hiding this comment.
LGTM.
I guess with a minor change (see inline comment) this might be mergeable already, even when the Plone Site is not yet dexterity.
I am going through the PRs to see which might be merged already, making the dexterity site root PLIP a bit smaller.
This would need yet another merge of master into this branch, or a rebase and force push, plus tested on its own in Jenkins.
plone/dexterity/schema.py
Outdated
| @@ -326,7 +329,12 @@ def portalTypeToSchemaName(portal_type, schema=u"", prefix=None, suffix=None): | |||
| """Return a canonical interface name for a generated schema interface. | |||
| """ | |||
| if prefix is None: | |||
| prefix = '/'.join(getUtility(ISiteRoot).getPhysicalPath())[1:] | |||
| if portal_type == 'Plone Site': | |||
| fti = getUtility(IDexterityFTI, name=portal_type) | |||
There was a problem hiding this comment.
If we use queryUtility here, and catch the case where it is None, then this PR could probably be merged already before all the other dexterity site root PRs. It is a guess.
…aName. That makes this code usable when Plone Site is not (yet) a dexterity item. I doubt that this code path is ever reached when the Plone Site FTI is not dexterity, but let's be careful.
|
@jenkins-plone-org please run jobs |
|
Jenkins is green on 5.2 and 6.0 without needing the other site root PRs. For me it is fine to merge. |
don't merge