Dx container site root

CHANGES.rst

@@ -179,6 +179,9 @@ New features:
 
 Bug fixes:
 
+- Fix ft._updateProperty so it doesn't break when receiving an empty value.
+  This happens when an DX FTI is part of a Generic Setup baseline import.
+  [jaroel]
 - Other Python 3 compatibility fixes
   [ale-rt, pbauer, jensens]
 

plone/dexterity/content.py

@@ -50,6 +50,7 @@
 from zope.security.interfaces import IPermission
 
 import six
+import warnings
 import threading
 
 
@@ -773,7 +774,19 @@ def __getattr__(self, name):
             pass
 
         # Be specific about the implementation we use
-        return CMFOrderedBTreeFolderBase.__getattr__(self, name)
+        if self._tree is not None:
+            return CMFOrderedBTreeFolderBase.__getattr__(self, name)
+
+        raise AttributeError(name)
+
+    # XXX do we really want to handle this kind of cases, or is this a ID-10-T
+    # thingy?
+    # def __setattr__(self, name, obj):
+    #     if self._tree is not None and name in self:
+    #         # We're trying to set an item via dotted name...
+    #         del self[name]
+    #         self[name] = obj
+    #     super(Container, self).__setattr__(name, obj)
 
     @security.protected(permissions.DeleteObjects)
     def manage_delObjects(self, ids=None, REQUEST=None):

plone/dexterity/factory.py

@@ -30,7 +30,7 @@ def description(self):
     def __call__(self, *args, **kw):
         fti = getUtility(IDexterityFTI, name=self.portal_type)
 
-        klass = resolveDottedName(fti.klass)
+        klass = resolveDottedName(fti.klass) if fti.klass else None
         if klass is None or not callable(klass):
             raise ValueError(
                 "Content class %s set for type %s is not valid" %

plone/dexterity/fti.py

@@ -193,7 +193,7 @@ def __init__(self, *args, **kwargs):
 
         # Set the content_meta_type from the klass
 
-        klass = utils.resolveDottedName(self.klass)
+        klass = utils.resolveDottedName(self.klass) if self.klass else None
         if klass is not None:
             self.content_meta_type = getattr(klass, 'meta_type', None)
 
@@ -234,7 +234,7 @@ def Metatype(self):
         if self.content_meta_type:
             return self.content_meta_type
         # BBB - this didn't use to be set
-        klass = utils.resolveDottedName(self.klass)
+        klass = utils.resolveDottedName(self.klass) if self.klass else None
         if klass is not None:
             self.content_meta_type = getattr(klass, 'meta_type', None)
         return self.content_meta_type
@@ -307,7 +307,9 @@ def _updateProperty(self, id, value):
 
             # Update meta_type from klass
             if id == 'klass':
-                klass = utils.resolveDottedName(new_value)
+                klass = None
+                if new_value:
+                    klass = utils.resolveDottedName(new_value)
                 if klass is not None:
                     self.content_meta_type = getattr(klass, 'meta_type', None)
 

plone/dexterity/schema.py

@@ -16,6 +16,7 @@
 from zope.component import getAllUtilitiesRegisteredFor
 from zope.component import getUtility
 from zope.component import queryUtility
+from zope.component.hooks import getSite
 from zope.dottedname.resolve import resolve
 from zope.globalrequest import getRequest
 from zope.interface import alsoProvides
@@ -65,9 +66,11 @@ def lookup_fti(portal_type, cache=True):
                 if fti_cache is None:
                     fti_cache = dict()
                     setattr(request, FTI_CACHE_KEY, fti_cache)
+                fti = None
                 if portal_type in fti_cache:
                     fti = fti_cache[portal_type]
-                else:
+
+                if fti is None:
                     fti_cache[portal_type] = fti = queryUtility(
                         IDexterityFTI,
                         name=portal_type
@@ -326,7 +329,12 @@ def portalTypeToSchemaName(portal_type, schema=u"", prefix=None, suffix=None):
     """Return a canonical interface name for a generated schema interface.
     """
     if prefix is None:
-        prefix = '/'.join(getUtility(ISiteRoot).getPhysicalPath())[1:]
+        if portal_type == 'Plone Site':
+            fti = getUtility(IDexterityFTI, name=portal_type)
+            siteroot = fti.__parent__
+        else:
+            siteroot = getUtility(ISiteRoot)
+        prefix = '/'.join(siteroot.getPhysicalPath())[1:]
     if suffix:
         prefix = '|'.join([prefix, suffix])