Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mode parameter instead of deprecated direction #130

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

mauritsvanrees
Copy link
Member

Fixes #102

I noticed that test.pt still used the deprecated direction='contain'. It did work, turning a landscape image into a square:

Screenshot 2022-08-12 at 14 16 42

With the newer mode="contain" the result would not have been so good, basically ignoring the setting:

Screenshot 2022-08-12 at 14 17 01

With this PR, the newer spelling works too.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

The gh-actions pass. Now I test these two PRs together:

https://github.com/plone/plone.scale/pull/66
https://github.com/plone/plone.namedfile/pull/130

They are not dependent on each other, but they change similar things, so it is good to test them in combination.

@jensens jensens merged commit d95b1cd into master Aug 13, 2022
@jensens jensens deleted the petschki-mode-scaling-take-2 branch August 13, 2022 15:01
@mauritsvanrees
Copy link
Member Author

The Jenkins tests were failing for plone.restapi. Let's hope that is because of the plone.scale changes. Otherwise we should revert temporarily.

@jensens
Copy link
Member

jensens commented Aug 13, 2022

:(

@mauritsvanrees
Copy link
Member Author

I have reverted the merge. I will open a new PR.

@mauritsvanrees mauritsvanrees restored the petschki-mode-scaling-take-2 branch August 13, 2022 20:05
@mauritsvanrees
Copy link
Member Author

New draft PR: #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "mode" parameter for scaling (direction is deprecated in plone.scale)
3 participants