Use mode parameter instead of deprecated direction (take 3) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
…r early. Otherwise it ends up in hashes and it negates the next condition. Some plone.restapi tests fail without this fix.
mauritsvanrees
force-pushed
the
petschki-mode-scaling-take-3
branch
from
beccf46 to
40b8977
Compare
|
This is ready for review now. Earlier some |
|
That should be: Trying again. |
|
Green! |
ale-rt
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
But
plone.restapihas four failures with this, and they should be fixed first. See https://jenkins.plone.org/job/plone-6.0-python-3.9/1361/