Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports are Python3 compatible #60

Merged
merged 3 commits into from
Oct 24, 2017
Merged

Imports are Python3 compatible #60

merged 3 commits into from
Oct 24, 2017

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Oct 21, 2017

No description provided.

@jensens
Copy link
Member

jensens commented Oct 23, 2017

@ale-rt I changed this one to the proposed six way, just to get a feeling for this.

@jensens jensens closed this Oct 23, 2017
@jensens jensens reopened this Oct 23, 2017
@ale-rt
Copy link
Member Author

ale-rt commented Oct 23, 2017

You are very welcome! I hope I will have some time to fix also the others.

mauritsvanrees
mauritsvanrees requested changes Oct 24, 2017
View reviewed changes
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

six should be in the install_requires

@mauritsvanrees mauritsvanrees merged commit f50db20 into master Oct 24, 2017
@mauritsvanrees mauritsvanrees deleted the py3 branch October 24, 2017 22:16
@pbauer pbauer mentioned this pull request Nov 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees
No one assigned
Labels
04 type: enhancement 23 status: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ale-rt @jensens @mauritsvanrees @jenkins-plone-org