Fix tests for https://github.com/plone/Products.CMFPlone/issues/3486 #1359
Conversation
|
@pbauer thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@pbauer can you elaborate on this? I guess we might need an if/else here for different Plone versions? Keep in mind that plone.restapi needs to support Plone 5.2 and Plone 6 at the same time. |
|
I'll add if/else clauses. After #1364 is merged we can check here for Plone 6 or not without messing with alphas. |
|
Wrong, since the tests run with 5.2 and 6.0.0a4 and 6.0 coredev all cases need to be covered. I'd rather set |
|
I guess now it's ready for merge |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
Tests are finally green |
No description provided.