Cleanup robot tests #1720
Cleanup robot tests #1720
Conversation
✅ Deploy Preview for plone-restapi canceled.
|
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
gforcada
force-pushed
the
cleanup-robot-tests
branch
from
6d0c397
to
6b992b2
Compare
|
@gforcada Tests are failing because there are still imports from plone.app.robotframework |
gforcada
force-pushed
the
cleanup-robot-tests
branch
from
6b992b2
to
a6c2bbd
Compare
gforcada
force-pushed
the
cleanup-robot-tests
branch
from
a6c2bbd
to
a13a231
Compare
|
Actually not in As this repository is still not We can keep the dependency here, to avoid the breakage, it does not feel clean, but at least works, hopefully 🍀 |
…lone.app.robotframework directly
|
@gforcada I'm trying it with plone.restapi's |
|
@jenkins-plone-org please run jobs |
|
@gforcada @davisagli did you folks run into this while trying Python 3.12 or rather the robotframework cleanup? I just started a branch here: and I was about to remove p.a.robotframework and friends because they cause trouble. I just want to avoid that we work on this at the same time...If that's the case I am happy to stop my efforts... |
|
@tisto I will merge this PR as soon as the jenkins builds finish. |
|
@davisagli thanks! 😄 |
It was not running for quite a long time ago already.