-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Python 3.12 on GHA #1722
Test Python 3.12 on GHA #1722
Conversation
✅ Deploy Preview for plone-restapi canceled.
|
@tisto thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
We can't officially declare support for Python 3.12 until there are releases of RestrictedPython and Zope that officially support it, right? |
@davisagli fair point. I wasn't aware of this... |
The coordination issue for 3.12 is: plone/Products.CMFPlone#3852 So far the tests for plone.api and plone.restapi are fixed, a few new version pins are needed (added by @pbauer ) and the jenkins jobs need to be hooked up so we do not regress, but the jobs are there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have merged the plone.rest
PR just now.
We can't officially declare support for Python 3.12 until there are releases of RestrictedPython and Zope that officially support it, right?
True for Plone as a whole, but for me it is fine if plone.restapi
already declares 3.12 support.
For me it is fine to merge as-is.
@gforcada are you already working on Python 3.12 for plone.restapi or did I get your comment about this on community.plone.org wrong?
https://community.plone.org/t/experiment-plone-6-0-7-on-python-3-12-0/17993/4