Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.12 on GHA #1722

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Test Python 3.12 on GHA #1722

merged 7 commits into from
Oct 18, 2023

Conversation

tisto
Copy link
Member

@tisto tisto commented Oct 14, 2023

@gforcada are you already working on Python 3.12 for plone.restapi or did I get your comment about this on community.plone.org wrong?

https://community.plone.org/t/experiment-plone-6-0-7-on-python-3-12-0/17993/4

@netlify
Copy link

netlify bot commented Oct 14, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 3536579
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/652af4e0d15edd00081872f1

@mister-roboto
Copy link

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@tisto tisto mentioned this pull request Oct 14, 2023
@tisto
Copy link
Member Author

tisto commented Oct 14, 2023

@jenkins-plone-org please run jobs

@tisto tisto requested review from davisagli and gforcada October 14, 2023 20:16
@davisagli
Copy link
Member

We can't officially declare support for Python 3.12 until there are releases of RestrictedPython and Zope that officially support it, right?

@tisto
Copy link
Member Author

tisto commented Oct 14, 2023

@davisagli fair point. I wasn't aware of this...

@gforcada
Copy link
Member

The coordination issue for 3.12 is: plone/Products.CMFPlone#3852

So far the tests for plone.api and plone.restapi are fixed, a few new version pins are needed (added by @pbauer ) and the jenkins jobs need to be hooked up so we do not regress, but the jobs are there.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have merged the plone.rest PR just now.

We can't officially declare support for Python 3.12 until there are releases of RestrictedPython and Zope that officially support it, right?

True for Plone as a whole, but for me it is fine if plone.restapi already declares 3.12 support.

For me it is fine to merge as-is.

@mauritsvanrees mauritsvanrees merged commit 817b859 into main Oct 18, 2023
19 checks passed
@mauritsvanrees mauritsvanrees deleted the py-3.12 branch October 18, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants