Add support for Python 3.6. #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implies testing them separately. TODO: - remove duplicate code - bring back z2 for BBB
Reusing the code from wsgi.py in zserver.py, so it can be easily deleted when zserver is no longer supported.
But we use the same names used in zserver.py. The `WSGIServer` fixture is still to be developed.
[skip ci]
(Some plone tests do this.)
Without these changes the ZServer layer implicitly uses the Zope app in some
places. This breaks tests later on which run on the Zope layer with the
following traceback:
Traceback (most recent call last):
...
File ".../plone/testing/zope.py", line 244, in zopeApp
app = addRequestContainer(Zope2.app(connection), environ=environ)
File ".../Zope2/__init__.py", line 55, in app
return bobo_application(*args, **kw)
TypeError: 'NoneType' object is not callable
Merged
17 tasks
|
close in favor of #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently based on #44. (Only the commits after the
Merge commitare relevant.)Closes #38 (as it includes the changes of it.)
This PR requires that the
py3branch ofplone.app.testingto run successfully against coredev on Jenkins. See plone/buildout.coredev#480 for a test running bothpy3branches.