Python 3.6 new #50
Merged
Python 3.6 new #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implies testing them separately. TODO: - remove duplicate code - bring back z2 for BBB
Reusing the code from wsgi.py in zserver.py, so it can be easily deleted when zserver is no longer supported.
But we use the same names used in zserver.py. The `WSGIServer` fixture is still to be developed.
[skip ci]
(Some plone tests do this.)
[skip ci]
This shows more clearly the purpose of the module.
Without these changes the ZServer layer implicitly uses the Zope app in some
places. This breaks tests later on which run on the Zope layer with the
following traceback:
Traceback (most recent call last):
...
File ".../plone/testing/zope.py", line 244, in zopeApp
app = addRequestContainer(Zope2.app(connection), environ=environ)
File ".../Zope2/__init__.py", line 55, in app
return bobo_application(*args, **kw)
TypeError: 'NoneType' object is not callable
|
Lets see what happens with a PR job on 5.2 with |
|
@jensens wrote:
The result is a bit disappointing: 1185 broken tests. This looks like a problem on a deeper level. I currently do not have the time and energy to look into it. |
|
@icemac indeed, no problem, I will take a look soon. |
This was referenced Sep 27, 2018
Closed
This was a fun one. The zope.security.checker module has a module-global _checkers dict. This layer tries to manage it as a stack, where pushing to the stack copies the current dict and popping from the stack sets zope.security.checker._checkers back to the copy that was stored. But, it turns out that _checkers is imported from a C extension module, and that module keeps a pointer to the original dict that is not affected by the plone.testing stack pop. So subsequent lookups continue to use the old dict. To fix this I changed the stack pop operation to clear and update the dict instead of replacing it, so that the pointer in the C module is still valid. There was a similar but different problem with the pure-Python implementation: it sets _getChecker = _checkers.get initially and _getChecker was not updated by the stack pop. My workaround should also deal with this case.
davisagli
force-pushed
the
py3_disallow_commits
branch
from
7a5d836 to
c7c080b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is all from #48, plus rebase with master, plus additional changes from last sprints. sigh
It is what is used in Plone 5.2 coredev buildout right now.
In order to merge at least plone.app.testing needs also to be ready.
This really should be addressed and get merged, any input on open todos welcome!
cc pbauer @icemac @loechel
Closes #48