Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy-load draftjs libraries #1932

Closed
tiberiuichim opened this issue Oct 23, 2020 · 2 comments
Closed

Lazy-load draftjs libraries #1932

tiberiuichim opened this issue Oct 23, 2020 · 2 comments

Comments

@tiberiuichim
Copy link
Contributor

There's no reason to have them in the main client bundle. I think it would save at least 150kb gzipped size.
@tiberiuichim
Copy link
Contributor Author

  • react-beautiful-dnd also needs to go.
  • react-toastify
    -react-dnd-html5-backend
  • moment?
  • react-dropzone
  • diff.js
  • react-simple-code-editor
  • dnd-core
  • prismjs

Also, why do we load js zlib libraries?

silviubogan added a commit to silviubogan/volto that referenced this issue Nov 10, 2020
@silviubogan
Work on plone#1932 to lazy-load react-toastify in Volto
1d015c1
@nileshgulia1 nileshgulia1 mentioned this issue Dec 2, 2020
Merged
@davisagli
Copy link
Member

Looks like this was already done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davisagli @tiberiuichim