Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load react-dropzone #2044

Merged
merged 7 commits into from
Dec 4, 2020
Merged

Lazy load react-dropzone #2044

merged 7 commits into from
Dec 4, 2020

Conversation

nileshgulia1
Copy link
Member

lazy loading stuffs... #1932

@tiberiuichim
Copy link
Contributor

LGTM.

I've been looking to see if the waitFor(() => {}) pattern can be improved, but it looks like that, as long as we use snapshot based testing, we have to live with it?

testing-library/dom-testing-library#484 (comment)

@sneridagh sneridagh merged commit ac97e22 into master Dec 4, 2020
@sneridagh sneridagh deleted the lazy-load-libs branch December 4, 2020 18:21
sneridagh added a commit that referenced this pull request Dec 4, 2020
* master:
  feat(restapi): add emailSend action (#2042)
  Lazy load react-dropzone (#2044)
  Python3.9 compatibility (#2045)
  Multi-selected copy/paste blocks (#1951)
  Back to development
  Release 10.2.0
  Prepare for release
  Fix regression in the `getContent` action with the expandable missing (#2046)
  Generate language file of added missing German translations (#2036)
  Gh actions i18n (#2038)
  Back to development
  Release 10.1.0
  Prepare for release
  Update translations de (#2034)
  Update translations (#2033)
sneridagh added a commit that referenced this pull request Dec 12, 2020
* configascontext: (32 commits)
  Fix deps
  PoC refactoring using React Context for passing down the config in components
  Back to development
  Release 10.4.0
  Prepare for release
  Volto sites in production update (#2055)
  Add ability to filter the attributes that are saved in the ObjectBrowserWidget and add proper object_widget (#2053)
  adding video thumbnail for the .mp4 extension (#2052)
  Back to development
  Release 10.3.0
  Prepare for release
  Fix addons loader compatibility with Windows (#2047)
  Search depth (#2032)
  Tweak Cypress to avoid unfinished resource waiting (#2037)
  feat(restapi): add emailSend action (#2042)
  Lazy load react-dropzone (#2044)
  Python3.9 compatibility (#2045)
  Multi-selected copy/paste blocks (#1951)
  Back to development
  Release 10.2.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants