Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not use a hook-line name of function #4660

Open
tiberiuichim opened this issue Apr 6, 2023 · 1 comment
Open

Should not use a hook-line name of function #4660

tiberiuichim opened this issue Apr 6, 2023 · 1 comment

Comments

@tiberiuichim
Copy link
Contributor

volto/packages/volto-slate/src/blocks/Text/SlashMenu.jsx

Line 113 in c40e772

const useAllowedBlocks = !isEmpty(allowedBlocks);

In react code the use prefix is reserved for hooks, afaik
HyperDanisH added a commit to HyperDanisH/volto that referenced this issue Apr 8, 2023
@HyperDanisH
Fix plone#4660
7df9f6a 
Changed useAllowedBlocks variable name to isAllowedBlocksEmpty because use prefix is a reserved prefix in react for hooks.  (plone#4660)
HyperDanisH added a commit to HyperDanisH/volto that referenced this issue Apr 8, 2023
@HyperDanisH
Revert "Fix plone#4660"
385a5ab 
This reverts commit 7df9f6a.
@stevepiercy
Copy link
Collaborator

@sjain-hub please read and follow Contributing to Plone and First-time contributors.

@plone plone deleted a comment from sjain-hub Apr 8, 2023
Kaku-g added a commit to Kaku-g/volto that referenced this issue Apr 13, 2023
@Kaku-g
fixed the issue plone#4660 - shouldn't use a hook like function name…
a699105 
… for a variable!
@davisagli davisagli mentioned this issue May 6, 2023
Merged
Kaku-g added a commit to Kaku-g/volto that referenced this issue May 10, 2023
@Kaku-g
fixed issue plone#4660 with required changes
daa3530
Kaku-g added a commit to Kaku-g/volto that referenced this issue May 10, 2023
@Kaku-g
updated changelog for issue plone#4660
6772a6d
Kaku-g added a commit to Kaku-g/volto that referenced this issue May 10, 2023
@Kaku-g
updated changelog for issue plone#4660
67f088b
sneridagh added a commit that referenced this issue May 23, 2023
@Kaku-g @sneridagh
fixed the issue #4660 - shouldn't use a hook like function name for …
6e5f0ec 
…a variable (#4693)

Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this issue May 24, 2023
@Kaku-g @sneridagh
fixed the issue #4660 - shouldn't use a hook like function name for …
1eded35 
…a variable (#4693)

Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this issue May 24, 2023
@sneridagh @Kaku-g
fixed the issue #4660 - shouldn't use a hook like function name for … (
db63a16 
#4808)

Co-authored-by: Jatin Rawat <63788422+Kaku-g@users.noreply.github.com>
sneridagh added a commit that referenced this issue May 26, 2023
@sneridagh
Merge branch 'master' into typescript-support-in-core
54236f4 
* master:
  Release changelog for 16.20.7 (#4816)
  Release 17.0.0-alpha.8
  Add supported languages (#4811)
  Fix html tag lang attribute in SSR (#4803)
  Finnish translation forwardport (#4084) (#4810)
  Control panel for relations (#3382)
  Add guard in case of malformed blocks are present (at least id and title should be present) (#4802)
  fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693)
  Fix HMR of @plone/volto (#4799)
sneridagh added a commit that referenced this issue Jun 8, 2023
@sneridagh
Merge branch 'master' into rowblock
7e04701 
* master: (26 commits)
  Update Brazilian Portuguese translations (Fixes #4853)
  Convert header class to function (#4767)
  Use a Container from the registry in the Form component and fallback to the Semantic UI one (#4849)
  Display password validation error if available; update minimum password length (#4801)
  Do not break requires validation on number fields with value 0 (#4841)
  Search Block: Add support for advanced facets that are displayed on demand (#4784)
  Release 17.0.0-alpha.9
  Fix navigation sections in 404 pages (#4836)
  fix special characters in request urls (#4825)
  Fix block is undefined in StyleWrapper helper when building classnames (#4827)
  Fix glossary warning due to lack of empty line before a term (#4820)
  Release changelog for 16.20.7 (#4816)
  Release 17.0.0-alpha.8
  Add supported languages (#4811)
  Fix html tag lang attribute in SSR (#4803)
  Finnish translation forwardport (#4084) (#4810)
  Control panel for relations (#3382)
  Add guard in case of malformed blocks are present (at least id and title should be present) (#4802)
  fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693)
  Fix HMR of @plone/volto (#4799)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevepiercy @tiberiuichim