Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert header class to function #4767

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

Gomez
Copy link
Member

@Gomez Gomez commented May 15, 2023

No description provided.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit d3285e6
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/647e4b0faf32680008f710d8

@cypress
Copy link

cypress bot commented May 15, 2023

Passing run #5399 ↗︎

0 493 20 0 Flakiness 0

Details:

Remove cruft from the code
Project: Volto Commit: d3285e6e93
Status: Passed Duration: 13:51 💡
Started: Jun 5, 2023 8:55 PM Ended: Jun 5, 2023 9:09 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Gomez Gomez force-pushed the convert-class-to-function branch from 141ddf9 to cf436a7 Compare May 15, 2023 16:08
Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the shallowEqual, didn't know it before…

@sneridagh
Copy link
Member

@Gomez I took the liberty to amend the PR adding a façade hook instead of using directly the Redux hooks. This will help the transition to use the new modern data fetching when available.

@Tishasoumya-02 Please take a look at this pattern. We can discuss it during this week's meeting. I'll merge this PR when ready, since it was already in the pipeline.

/cc @JeffersonBledsoe @nileshgulia1 @jackahl

@sneridagh sneridagh merged commit d057fd6 into master Jun 6, 2023
@sneridagh sneridagh deleted the convert-class-to-function branch June 6, 2023 18:46
@sneridagh sneridagh mentioned this pull request Jun 6, 2023
sneridagh added a commit that referenced this pull request Jun 8, 2023
* master: (26 commits)
  Update Brazilian Portuguese translations (Fixes #4853)
  Convert header class to function (#4767)
  Use a Container from the registry in the Form component and fallback to the Semantic UI one (#4849)
  Display password validation error if available; update minimum password length (#4801)
  Do not break requires validation on number fields with value 0 (#4841)
  Search Block: Add support for advanced facets that are displayed on demand (#4784)
  Release 17.0.0-alpha.9
  Fix navigation sections in 404 pages (#4836)
  fix special characters in request urls (#4825)
  Fix block is undefined in StyleWrapper helper when building classnames (#4827)
  Fix glossary warning due to lack of empty line before a term (#4820)
  Release changelog for 16.20.7 (#4816)
  Release 17.0.0-alpha.8
  Add supported languages (#4811)
  Fix html tag lang attribute in SSR (#4803)
  Finnish translation forwardport (#4084) (#4810)
  Control panel for relations (#3382)
  Add guard in case of malformed blocks are present (at least id and title should be present) (#4802)
  fixed the issue #4660 - shouldn't use a hook like function name for a variable (#4693)
  Fix HMR of @plone/volto (#4799)
  ...
sneridagh added a commit that referenced this pull request Jun 25, 2023
* master:
  Release 17.0.0-alpha.14
  Linked headlines (#3540)
  Release notes for 16.20.8 16.21.0 16.21.1 (#4910)
  Spanish translation (#4896)
  Refactor Anontools (#4845)
  Update to plone-backend 6.0.5 (#4897)
  Release 17.0.0-alpha.13
  Enforce max upload size (#4868)
  Fix and improve the `addStyling` helper (#4880)
  Release 17.0.0-alpha.12
  Fix regression in horizontal scroll in contents view, add it back (#4872)
  Configurable Container component from registry for some key route views. (#4871)
  Allow to deselect color in ColorPickerWidget. (#4839)
  Release 17.0.0-alpha.11
  Pagination with router params (#4698)
  Release 17.0.0-alpha.10
  feat(slate): Add css identifier to slate style menu options (#4847)
  Update Brazilian Portuguese translations (Fixes #4853)
  Convert header class to function (#4767)
sneridagh added a commit that referenced this pull request Jun 26, 2023
* master: (29 commits)
  Remove anonymous function calls. Remove default exports from. (#4917)
  Release 17.0.0-alpha.14
  Linked headlines (#3540)
  Release notes for 16.20.8 16.21.0 16.21.1 (#4910)
  Spanish translation (#4896)
  Refactor Anontools (#4845)
  Update to plone-backend 6.0.5 (#4897)
  Release 17.0.0-alpha.13
  Enforce max upload size (#4868)
  Fix and improve the `addStyling` helper (#4880)
  Release 17.0.0-alpha.12
  Fix regression in horizontal scroll in contents view, add it back (#4872)
  Configurable Container component from registry for some key route views. (#4871)
  Allow to deselect color in ColorPickerWidget. (#4839)
  Release 17.0.0-alpha.11
  Pagination with router params (#4698)
  Release 17.0.0-alpha.10
  feat(slate): Add css identifier to slate style menu options (#4847)
  Update Brazilian Portuguese translations (Fixes #4853)
  Convert header class to function (#4767)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants