Upgrade slate libraries; fix empty link element left hanging when hit enter at end of link #5186
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@iFlameing if you can, please take over this PR. Taking into consideration that I had to upgrade the slate lib, there may be unforeseen bugs or changes, so a bit of live testing wouldn't hurt. |
|
@tiberiuichim Now it is ready for review. |
| @@ -42,6 +42,15 @@ | |||
| border-color: rgba(120, 192, 215, 0.75); | |||
| } | |||
|
|
|||
| .block-editor-title, | |||
There was a problem hiding this comment.
isn't there a generic slate editor class? They all exhibit this behavior, let's keep this simple.
There was a problem hiding this comment.
Turns out they do not! Maybe a change in the new one?
|
@tiberiuichim what's the status of this one? |
* main: Release 17.3.0 Fix DatetimeWidget on FF, the button default if no type is set is sen… (#5343) Call applyBlockDefaults from addBlock/insertBlock, add initialValue() configuration option for blocks (#5320) A11y - Updated aria-labels for landmarks, added landmark for sidebar and plug skiplinks (#5290) (FIX): put padding so the text is not clipped (#5305) Add upgrade docs for users of `@kitconcept/volto-blocks-grid` addon (#5333) Add new multilingual acceptance tests with Seamless mode enabled (#5332) Fix reference to installation (#5328) Fix compare translations view (#5327) Release 17.2.0 Fix to return correct results when loading the search block from a URL (#5298) Allow multiple path criteria (#5317)
|
@sneridagh I will update the branch. |
|
@sneridagh I tested locally and cypress is working perfectly fine. |
|
I had to revert to use the last good known version of working |
|
@stevepiercy added an upgrade notice, please take a look. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
I had to upgrade the slate library, as it introduces an
editor.normalize()function that can cleanup the links.There's one styling fix that needs to be done, the new slate lib triggers a
:focus-visibleand needs to be disabled withoutline: 0px.